Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebuild for libarrow 10.0.1 #58

Merged
merged 6 commits into from
Dec 7, 2022
Merged

Conversation

h-vetinari
Copy link
Member

Following conda-forge/arrow-cpp-feedstock#875; output arrow-cpp was renamed to libarrow.

@h-vetinari h-vetinari requested review from a team as code owners December 4, 2022 09:51
@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@h-vetinari
Copy link
Member Author

Not sure how I should pass CXXFLAGS in a way that they get picked up by ${R} CMD INSTALL... Any tips @conda-forge/help-r?

@h-vetinari
Copy link
Member Author

This also goes for windows, where we need to set C++17

@@ -11,4 +11,4 @@ if [[ "${target_platform}" == osx-* ]]; then
export ARROW_R_CXXFLAGS="${ARROW_R_CXXFLAGS} -D_LIBCPP_DISABLE_AVAILABILITY"
fi

$R CMD INSTALL --build r/.
${R} CMD INSTALL --build r/. ${R_ARGS}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is necessary for cross-compilation to work, apparently

@h-vetinari
Copy link
Member Author

@xhochy PTAL, I think this should be good to go 🙃

@h-vetinari
Copy link
Member Author

@conda-forge-admin, please rerender

@xhochy xhochy merged commit 494d0e6 into conda-forge:main Dec 7, 2022
@h-vetinari h-vetinari deleted the libarrow branch December 7, 2022 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants