-
-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated build recipe and patches to ray-1.3.0 #14
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
a7926e0
Updated build recipe and patches to ray-1.3.0
gshimansky 19310c5
Restored missing dataclasses
gshimansky a825bb4
Fixed setting up junctions on windows for archive
gshimansky b066b0e
Update bazel version to latest that seems to work
gshimansky ee13348
Disable runfiles on windows because symlinks require elevation
gshimansky f2f81a0
Add "serve" entry point to ray-serve subpackage
vnlitvinov cf2d8cb
reset build number for new version
h-vetinari dc8ad44
Adapt metrics_agent test for ray 1.3.0
vnlitvinov File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20 changes: 10 additions & 10 deletions
20
recipe/patches/0005-Disable-making-non-core-entry-scripts.patch
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,31 +1,31 @@ | ||
From 63830f8977e09fde3e70b42f01b0acc2c446a7dd Mon Sep 17 00:00:00 2001 | ||
From 82817f12571058d235ca813e77a96cf2fc24f411 Mon Sep 17 00:00:00 2001 | ||
From: Vasily Litvinov <vasilij.n.litvinov@intel.com> | ||
Date: Tue, 10 Nov 2020 23:26:35 +0300 | ||
Subject: [PATCH 05/15] Disable making non-core entry scripts | ||
Subject: [PATCH 05/14] Disable making non-core entry scripts | ||
|
||
--- | ||
python/setup.py | 8 ++++---- | ||
1 file changed, 4 insertions(+), 4 deletions(-) | ||
|
||
diff --git a/python/setup.py b/python/setup.py | ||
index a1542a7a2..5f68ae765 100644 | ||
index 0575ad3a1..8ed7e07a9 100644 | ||
--- a/python/setup.py | ||
+++ b/python/setup.py | ||
@@ -447,10 +447,10 @@ setuptools.setup( | ||
@@ -442,10 +442,10 @@ setuptools.setup( | ||
entry_points={ | ||
"console_scripts": [ | ||
"ray=ray.scripts.scripts:main", | ||
- "rllib=ray.rllib.scripts:cli [rllib]", | ||
- "tune=ray.tune.scripts:cli", | ||
- "ray-operator=ray.operator.operator:main", | ||
- "ray-operator=ray.ray_operator.operator:main", | ||
- "serve=ray.serve.scripts:cli", | ||
+ # "rllib=ray.rllib.scripts:cli [rllib]", | ||
+ # "tune=ray.tune.scripts:cli", | ||
+ # "ray-operator=ray.operator.operator:main", | ||
+ # "serve=ray.serve.scripts:cli", | ||
+ #"rllib=ray.rllib.scripts:cli [rllib]", | ||
+ #"tune=ray.tune.scripts:cli", | ||
+ #"ray-operator=ray.ray_operator.operator:main", | ||
+ #"serve=ray.serve.scripts:cli", | ||
] | ||
}, | ||
include_package_data=True, | ||
-- | ||
2.11.0 | ||
2.28.0 | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel we should be setting those entry points in the appropriate sub-packages.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
either that (if they need special requirements and those subpackages provide those) or allow them be in
ray-core
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This patch is taken verbatim from ray-1.2.0, no changes done to how these subpackages were handled in version 1.2.0
https://github.com/conda-forge/ray-packages-feedstock/blob/master/recipe/patches/0005-Disable-making-non-core-entry-scripts.patch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added
serve
entry point toray-serve
. I suggest keepingray-operator
removed for now as it's unclear to which package it should belong. We can wait for someone coming and raising an issue I think :)