Build both static and shared libraries on Unix and Windows platforms #15

wesm · 2018-09-27T18:19:52Z

Checklist

[x ] Used a fork of the feedstock to propose changes
Bumped the build number (if the version is unchanged)
Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)

conda-forge-linter · 2018-09-27T18:20:00Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

wesm · 2018-09-27T18:20:11Z

@conda-forge-admin, please rerender

conda-forge-linter · 2018-09-27T18:21:31Z

Hi! This is the friendly automated conda-forge-webservice.

I tried to re-render for you, but it looks like there was nothing to do.

conda-forge-linter · 2018-09-27T18:21:36Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

scopatz · 2018-09-27T19:43:23Z

Thanks for putting this in @wesm! Any interest in adding yourself as a maintainer here? I think you probably care about this package more than some of the current maintainers 😉

wesm · 2018-09-27T20:17:26Z

Done, I added @pitrou @xhochy and @kszucs as maintainers

isuruf · 2018-09-27T20:19:55Z

Does this close #10? Windows is still disabled

scopatz · 2018-09-27T20:20:39Z

No this doesn't seem to enable #10

wesm · 2018-09-27T20:22:18Z

Oh let me try to enable it then

scopatz · 2018-09-27T20:24:15Z

To be clear, you'll need to remove the win selector here and then rerender

wesm · 2018-09-27T20:26:48Z

@conda-forge-admin, please rerender

scopatz · 2018-09-28T13:53:25Z

Looks like the windows builds fail with:

Setting environment for using Microsoft Visual Studio 2008 x64 tools.
-- The CXX compiler identification is MSVC 15.0.30729.1
-- Check for working CXX compiler: C:/Program Files (x86)/Microsoft Visual Studio 9.0/VC/bin/amd64/cl.exe
-- Check for working CXX compiler: C:/Program Files (x86)/Microsoft Visual Studio 9.0/VC/bin/amd64/cl.exe -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
CMake Error at CMakeLists.txt:26 (message):
  you need Visual Studio 2015 or later

wesm · 2018-09-28T13:57:53Z

OK, so Python 3.5 or later I guess. I'll have to look into it later, if someone wants to push changes here please go ahead

scopatz · 2018-09-28T20:01:36Z

Note, that we are about to drop explicit support for python v3.5 if that helps!

conda-forge-linter · 2018-10-02T13:46:47Z

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

The requirements section contained an unexpected subsection name. skip is not a valid subsection name.

wesm · 2018-10-02T13:46:48Z

@conda-forge-admin, please rerender

wesm · 2018-10-02T13:47:29Z

@conda-forge-admin, please rerender

conda-forge-linter · 2018-10-02T13:47:35Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

wesm · 2018-10-02T13:51:39Z

@scopatz is this the right windows skip clause?

  skip: true  # [win and (py36 or vc<14)]

scopatz · 2018-10-02T13:55:24Z

@wesm - what are you trying to skip? That looks like it is going to skip all versions of windows, effectively

wesm · 2018-10-02T13:58:05Z

I tried to follow this C library pattern:

https://github.com/conda-forge/brotli-feedstock/blob/master/recipe/meta.yaml#L14

I guess that's not right. I'm copying the recipe from arrow-cpp-feedstock now (another C++11-only library)

wesm · 2018-10-02T13:58:15Z

@conda-forge-admin, please rerender

scopatz · 2018-10-02T14:09:58Z

What you have now looks more correct. I am not a deep windows build expert, so you might want to ask on gitter, but if this works and passes, I'll merge it

wesm · 2018-10-02T14:12:06Z

👍

scopatz · 2018-10-02T20:10:49Z

Looks like the windows build failed 😢

[ 31%] Building CXX object CMakeFiles/re2.dir/util/rune.cc.obj
rune.cc
[ 32%] Building CXX object CMakeFiles/re2.dir/util/strutil.cc.obj
strutil.cc
[ 33%] Linking CXX shared library re2.dll
NMAKE : fatal error U1077: 'C:\bld\re2_1538510221475\_build_env\Library\bin\cmake.exe' : return code '0xc0000005'
Stop.
NMAKE : fatal error U1077: '"C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\BIN\amd64\nmake.exe"' : return code '0x2'
Stop.
NMAKE : fatal error U1077: '"C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\BIN\amd64\nmake.exe"' : return code '0x2'
Stop.
Traceback (most recent call last):
  File "C:\Miniconda36-x64\Scripts\conda-build-script.py", line 10, in <module>

wesm · 2018-10-02T20:12:13Z

Hm. Guess we should try the normal MSVC build

isuruf · 2018-10-02T20:14:11Z

Can you try something like, https://github.com/conda-forge/snappy-feedstock/blob/4ec260701d1a8489e8a60010e215b72b7b5ec4c9/recipe/bld.bat#L3-L5 ?

wesm · 2018-10-04T08:59:35Z

Appears to be building now. What's this all about?

The system cannot find the path specified.
Traceback (most recent call last):
  File "C:\Miniconda36-x64\Scripts\conda-build-script.py", line 10, in <module>
    sys.exit(main())
  File "C:\Miniconda36-x64\lib\site-packages\conda_build\cli\main_build.py", line 438, in main
    execute(sys.argv[1:])
  File "C:\Miniconda36-x64\lib\site-packages\conda_build\cli\main_build.py", line 429, in execute
    verify=args.verify)
  File "C:\Miniconda36-x64\lib\site-packages\conda_build\api.py", line 201, in build
    notest=notest, need_source_download=need_source_download, variants=variants)
  File "C:\Miniconda36-x64\lib\site-packages\conda_build\build.py", line 2204, in build_tree
    notest=notest,
  File "C:\Miniconda36-x64\lib\site-packages\conda_build\build.py", line 1394, in build
    windows.build(m, build_file, stats=build_stats)
  File "C:\Miniconda36-x64\lib\site-packages\conda_build\windows.py", line 316, in build
    check_call_env(cmd, cwd=src_dir, stats=stats)
  File "C:\Miniconda36-x64\lib\site-packages\conda_build\utils.py", line 313, in check_call_env
    return _func_defaulting_env_to_os_environ('call', *popenargs, **kwargs)
  File "C:\Miniconda36-x64\lib\site-packages\conda_build\utils.py", line 293, in _func_defaulting_env_to_os_environ
    raise subprocess.CalledProcessError(proc.returncode, _args)
subprocess.CalledProcessError: Command '['cmd.exe', '/c', 'bld.bat']' returned non-zero exit status 1.
Command exited with code 1

scopatz · 2018-10-04T14:45:49Z

That seems odd, perhaps a conda-build issue. Maybe bring it up on the gitter or conda-build

isuruf · 2018-10-04T15:21:16Z

recipe/bld.bat

+nmake
+if errorlevel 1 exit 1
+
+copy Release\re2.lib %LIBRARY_DIR%\re2_static.lib


LIBRARY_DIR -> LIBRARY_LIB

wesm · 2018-10-05T11:22:27Z

Ideas?

scopatz · 2018-10-05T14:49:50Z

recipe/bld.bat

+
+nmake
+if errorlevel 1 exit 1
+


You are not doing an nmake install here, not sure if that is needed.

Can't do that because it would clobber the DLL import lib re2.lib

Ahh Ok, that makes sense. Is there a way we could turn echo on, so that we can see what is actually being run?

wesm · 2018-10-06T14:39:15Z

OK, adding echo shows what's wrong:

(C:\bld\re2_1538829964940\_build_env) C:\bld\re2_1538829964940\work\cmake-build>copy Release\re2.lib C:\bld\re2_1538829964940\_h_env\Library\lib\re2_static.lib 
The system cannot find the path specified.
(C:\bld\re2_1538829964940\_build_env) C:\bld\re2_1538829964940\work\cmake-build>if errorlevel 1 exit 1

I will fix and then merge once it's working

wesm · 2018-10-07T08:41:12Z

@scopatz can you merge this? Thanks!

scopatz · 2018-10-07T13:51:31Z

Glad to see this working!

Build both static and shared libraries on Unix and Windows platforms

f9bd54b

Add more maintainers

d38a517

Build on Windows to see

ad2aa1d

MNT: Re-rendered with conda-smithy 3.1.12 and pinning 2018.09.27

711737e

Build using Makefile on Linux, skip on Windows vc<14

ea279b9

Fix meta.yaml

44b1664

conda-forge-admin and others added 2 commits October 2, 2018 13:47

MNT: Re-rendered with conda-smithy 3.1.12 and pinning 2018.10.01

8594f62

Update to October 1 release

d7096ad

Use pattern from arrow-cpp-feedstock

da43d3c

MNT: Re-rendered with conda-smithy 3.1.12 and pinning 2018.10.01

e1bed00

Add workaround for windows

8cb1b1b

wesm mentioned this pull request Oct 4, 2018

ARROW-3331: [Gandiva][C++] Add re2 to toolchain apache/arrow#2695

Closed

isuruf reviewed Oct 4, 2018

View reviewed changes

wesm mentioned this pull request Oct 4, 2018

ARROW-3382: [Gandiva][C++] Run tests in travis apache/arrow#2705

Closed

Fix wrong env variable name

b43f155

scopatz reviewed Oct 5, 2018

View reviewed changes

add echo

dc1caaa

Fix path to re2.lib

f2cdec1

scopatz merged commit 92f1133 into conda-forge:master Oct 7, 2018

Build both static and shared libraries on Unix and Windows platforms #15

Build both static and shared libraries on Unix and Windows platforms #15

Conversation

wesm commented Sep 27, 2018 • edited Loading

conda-forge-linter commented Sep 27, 2018

wesm commented Sep 27, 2018

conda-forge-linter commented Sep 27, 2018

conda-forge-linter commented Sep 27, 2018

scopatz commented Sep 27, 2018

wesm commented Sep 27, 2018

isuruf commented Sep 27, 2018

scopatz commented Sep 27, 2018

wesm commented Sep 27, 2018

scopatz commented Sep 27, 2018

wesm commented Sep 27, 2018

scopatz commented Sep 28, 2018

wesm commented Sep 28, 2018

scopatz commented Sep 28, 2018

conda-forge-linter commented Oct 2, 2018

wesm commented Oct 2, 2018

wesm commented Oct 2, 2018

conda-forge-linter commented Oct 2, 2018

wesm commented Oct 2, 2018

scopatz commented Oct 2, 2018

wesm commented Oct 2, 2018

wesm commented Oct 2, 2018

scopatz commented Oct 2, 2018

wesm commented Oct 2, 2018

scopatz commented Oct 2, 2018

wesm commented Oct 2, 2018

isuruf commented Oct 2, 2018

wesm commented Oct 4, 2018

scopatz commented Oct 4, 2018

isuruf Oct 4, 2018

Choose a reason for hiding this comment

wesm Oct 4, 2018

Choose a reason for hiding this comment

wesm commented Oct 5, 2018

scopatz Oct 5, 2018

Choose a reason for hiding this comment

wesm Oct 5, 2018 • edited Loading

Choose a reason for hiding this comment

scopatz Oct 5, 2018

Choose a reason for hiding this comment

wesm commented Oct 6, 2018

wesm commented Oct 7, 2018

scopatz commented Oct 7, 2018

wesm commented Sep 27, 2018 •

edited

Loading

wesm Oct 5, 2018 •

edited

Loading