Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake's FindRuby on Windows can't find the ruby 2.7 installed by conda-forge #43

Closed
traversaro opened this issue Nov 8, 2020 · 4 comments · Fixed by conda-forge/cmake-feedstock#128

Comments

@traversaro
Copy link
Contributor

The upstream CMake issue is https://gitlab.kitware.com/cmake/cmake/-/issues/21066, but I wanted to open an issue also here for visibility. The problem is that FindRuby has not been updated with the latest possible names of the Ruby library. In my case for example, I have:

-- _Ruby_POSSIBLE_LIB_NAMES: ruby;ruby-static;ruby2.7;ruby27;ruby-2.7;ruby-2.7.2;x64-msvcr141-ruby272;x64-msvcr141-ruby272-static;x64-msvcrt-ruby272;x64-msvcrt-ruby272-static

bu the library is actually called x64-vcruntime140-ruby270 .

@traversaro traversaro changed the title CMake's FindRuby on Windows can't find the ruby installed by conda CMake's FindRuby on Windows can't find the ruby 2.7 installed by conda-forge Nov 8, 2020
@traversaro
Copy link
Contributor Author

@traversaro
Copy link
Contributor Author

CMake PR: https://gitlab.kitware.com/cmake/cmake/-/merge_requests/5486 .

At the fix is for an environmental regression, the change has been target toward the 3.19 release branch, and so should be part of the next 3.19.0 CMake release (that I guess is going to happen in November).

@traversaro
Copy link
Contributor Author

CMake PR: https://gitlab.kitware.com/cmake/cmake/-/merge_requests/5486 .

At the fix is for an environmental regression, the change has been target toward the 3.19 release branch, and so should be part of the next 3.19.0 CMake release (that I guess is going to happen in November).

PR on CMake merged, let's wait for the CMake 3.19 release and its adoption in conda-forge to close the issue.

@traversaro
Copy link
Contributor Author

traversaro commented Nov 21, 2020

The fix was released as part of CMake 3.19.0 : https://discourse.cmake.org/t/cmake-3-19-0-available-for-download/2198 , so we will fix the issue once CMake 3.19 is released in conda-forge . However CMake 3.19.0 contains a quite critical regression (it breaks for example LLVM, see https://gitlab.kitware.com/cmake/cmake/-/issues/21469) that it will be fixed in the next patch release, so it may be better to just wait for CMake 3.19.1 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant