Update cmake to 3.19.1 #128
Conversation
traversaro
requested review from
blowekamp,
groutr,
jakirkham,
jschueller,
marcelotrevisani,
msarahan,
ocefpaf,
scopatz and
tadeu
as code owners
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
|
@conda-forge-admin, please rerender |
…da-forge-pinning 2020.11.24.19.24.28
|
This seems to fail on win and osx. |
The Windows failure seems the good old "the user forgot to enable openssl" but indeed it seems that it was not enabled before, probably there was some auto-detected options that was enabling it before. I can look into enabling openssl explicitly just to be sure. Good old |
|
Yeah, I am not sure about the osx-amd64 issues. I would be ok allowing that platform as a failure since it so new. But we should check with other @conda-forge/cmake maintainers |
|
Thanks @isuruf for fixing osx-arm64! |
|
The Windows failure appears due to the fact that CMAKE_USE_WINSSL option was renamed to CMAKE_USE_SCHANNEL, and moved from ON by default to OFF by default (not sure if it was intentional). |
| @@ -6,14 +6,19 @@ CMAKE_ARGS="$CMAKE_ARGS -DCURSES_INCLUDE_PATH=${PREFIX}/include -DBUILD_CursesDi | |||
| CMAKE_ARGS="$CMAKE_ARGS -DCMAKE_PREFIX_PATH=${PREFIX}" | |||
|
|
|||
| if [[ "$CONDA_BUILD_CROSS_COMPILATION" == "1" ]]; then | |||
| if [[ "$target_platform" == osx-* ]] && [[ "$MACOSX_DEPLOYMENT_TARGET" == 11.* || "$MACOSX_DEPLOYMENT_TARGET" == "10.15" ]]; then | |||
There was a problem hiding this comment.
@isuruf - do you want to add yourself as a maintainer here too?
There was a problem hiding this comment.
No, I don't. cc @conda-forge/core
There was a problem hiding this comment.
Isn't it more correct to ask @conda-forge/cmake?
Bump CMake to version 3.19.1 .
3.19.1 Release Notes : https://discourse.cmake.org/t/cmake-3-19-1-available-for-download/2228
3.19.0 Release Notes : https://discourse.cmake.org/t/cmake-3-19-0-available-for-download/2198
Fix conda-forge/ruby-feedstock#43 .
Checklist
0(if the version changed)conda-smithy(Use the phrase@conda-forge-admin, please rerenderin a comment in this PR for automated rerendering)