Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable fiddle extension also on Windows #81

Merged
merged 1 commit into from
Nov 24, 2021

Conversation

traversaro
Copy link
Contributor

@traversaro traversaro commented Oct 29, 2021

Required by conda-forge/libignition-tools-feedstock#12 (comment) . As the fiddle extentions is using libffi that is found by the custom build script via pkg-config, this PR enables the libffi and pkg-config dependencies also on Windows.

Tests have been added to ensure that the fiddle extention indeed loads fine.

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@traversaro
Copy link
Contributor Author

@conda-forge-admin, please rerender

@traversaro
Copy link
Contributor Author

traversaro commented Oct 29, 2021

This was way easier that I expected, but the test seems to pass fine.

@traversaro traversaro changed the title Try to enable fiddle extension Enable fiddle extension also on Windows Oct 29, 2021
@traversaro
Copy link
Contributor Author

The PR is ready for review @conda-forge/ruby .

@traversaro
Copy link
Contributor Author

@conda-forge-admin, please rerender

@traversaro
Copy link
Contributor Author

@conda-forge-admin, please rerender

@github-actions
Copy link
Contributor

github-actions bot commented Nov 3, 2021

Hi! This is the friendly automated conda-forge-webservice.
I tried to rerender for you, but it looks like there was nothing to do.

@traversaro
Copy link
Contributor Author

The PR is ready for review @conda-forge/ruby @wolfv . This should unblock conda-forge/libignition-tools-feedstock#12 (comment) .

@Tobias-Fischer
Copy link
Contributor

Any chance of merging this in @conda-forge/ruby @wolfv?

@wolfv wolfv merged commit 245e1dc into conda-forge:master Nov 24, 2021
@traversaro traversaro deleted the patch-3 branch November 24, 2021 15:30
@traversaro
Copy link
Contributor Author

traversaro commented Nov 24, 2021

And after all this time, I just realized that I forgot to bump the build number. -_-
Probably I forgot to update the PR after #82 .

@traversaro
Copy link
Contributor Author

And after all this time, I just realized that I forgot to bump the build number. -_-

New PR in #86 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants