Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scikit-build-core v0.10.0 #49

Merged
merged 2 commits into from
Aug 6, 2024
Merged

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Aug 6, 2024

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

Requesting a package update (before the autotick bot does so automatically). I have a relatively urgent need for this update to align with PyPI's latest version.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@bdice
Copy link
Contributor Author

bdice commented Aug 6, 2024

@conda-forge-admin, please rerender

@bdice bdice marked this pull request as ready for review August 6, 2024 21:46
@bdice bdice requested review from henryiii, jcfr, thewtex and a team as code owners August 6, 2024 21:46
Copy link
Contributor

github-actions bot commented Aug 6, 2024

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/scikit-build-core-feedstock/actions/runs/10274388454.

@henryiii
Copy link
Contributor

henryiii commented Aug 6, 2024

I have a relatively urgent need for this update to align with PyPI's latest version.

You have my curiosity? :)

@henryiii henryiii added the automerge Merge the PR when CI passes label Aug 6, 2024
Copy link
Contributor

github-actions bot commented Aug 6, 2024

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

  • linter: passed
  • azure: passed

Thus the PR was passing and merged! Have a great day!

@bdice
Copy link
Contributor Author

bdice commented Aug 6, 2024

I have a relatively urgent need for this update to align with PyPI's latest version.

We're getting ready to ship a new RAPIDS release (24.08). We haven't had bandwidth to keep up with some of the deprecations in scikit-build-core, and 0.10.0 breaks our builds. We would like to update our scikit-build-core pinnings to >=0.10 and set minimum-version = "0.10" rather than have conda builds using 0.9 and pip builds using 0.10.

The new changes are very welcome! We just want to migrate to 0.10 all at once, and in the next ~1 day if possible.

@bdice
Copy link
Contributor Author

bdice commented Aug 6, 2024

There is a failing test:

=================================== FAILURES ===================================
________________________ test_broken_code[BROKEN_CODE] _________________________

broken_define = 'BROKEN_CODE'
capfd = <_pytest.capture.CaptureFixture object at 0x7f8752c692e0>

    @pytest.mark.compile()
    @pytest.mark.configure()
    @pytest.mark.usefixtures("broken_fallback")
    @pytest.mark.parametrize("broken_define", ["BROKEN_CMAKE", "BROKEN_CODE"])
    def test_broken_code(broken_define: str, capfd: pytest.CaptureFixture[str]):
        build_wheel("dist", {f"cmake.define.{broken_define}": "1"})
        wheel = Path("dist") / "broken_fallback-0.0.1-py3-none-any.whl"
        with zipfile.ZipFile(wheel) as f:
            file_names = set(f.namelist())
    
        assert file_names == {
            "broken_fallback-0.0.1.dist-info/RECORD",
            "broken_fallback-0.0.1.dist-info/WHEEL",
            "broken_fallback-0.0.1.dist-info/METADATA",
        }
    
        out, err = capfd.readouterr()
        assert "retrying due to override..." in out
    
        if broken_define == "BROKEN_CMAKE":
            assert "Broken CMake" in err
            assert "CMake Error at CMakeLists.txt" in err
            assert "CMake configuration failed" in out
        else:
>           assert "Broken code" in out
E           assert 'Broken code' in '*** scikit-build-core 0.10.0 using CMake 3.30.2 (wheel)\n*** Configuring CMake...\nloading initial cache file /tmp/tmpg1jwmfr6/build/CMakeInit.txt\n-- The C compiler identification is GNU 12.4.0\n-- Detecting C compiler ABI info\n-- Detecting C compiler ABI info - done\n-- Check for working C compiler: $PREFIX/bin/x86_64-conda-linux-gnu-cc - skipped\n-- Detecting C compile features\n-- Detecting C compile features - done\n-- Found Python: $PREFIX/bin/python3.12 (found version "3.12.4") found components: Interpreter Development.Module\n-- Configuring done (0.4s)\n-- Generating done (0.0s)\n-- Build files have been written to: /tmp/tmpg1jwmfr6/build\n*** Building project with Unix Makefiles...\n[ 50%] Building C object CMakeFiles/example.dir/main.c.o\n\n*** CMake build failed - retrying due to override...\n*** scikit-build-core 0.10.0 (wheel)\n*** Making wheel...\n*** Created broken_fallback-0.0.1-py3-none-any.whl\n'

@henryiii
Copy link
Contributor

henryiii commented Aug 6, 2024

I think the compiler error messages are suppressed? It's supposed to be print this out with #error. I'm not too worried about it (otherwise it's behaving correctly), so we can skip it for now, and figure out what conda is setting to cause the compiler error message to be hidden later.

@github-actions github-actions bot removed the automerge Merge the PR when CI passes label Aug 6, 2024
Copy link
Contributor

github-actions bot commented Aug 6, 2024

Hi! This is the friendly conda-forge automerge bot!

Commits were made to this PR after the automerge label was added. For security reasons, I have disabled automerge by removing the automerge label. Please add the automerge label again (or ask a maintainer to do so) if you'd like to enable automerge again!

@henryiii
Copy link
Contributor

henryiii commented Aug 6, 2024

0.10.0 breaks our builds

It's not supposed to break any existing builds, care to elaborate?

@henryiii henryiii added the automerge Merge the PR when CI passes label Aug 6, 2024
@bdice
Copy link
Contributor Author

bdice commented Aug 6, 2024

0.10.0 breaks our builds

It's not supposed to break any existing builds, care to elaborate?

I think we're relying on some aspect of cmake.minimum-version behavior that was changed? I don't have a specific build log at this moment. We have tracked some of this in rapidsai/build-planning#58.

@github-actions github-actions bot merged commit 78e0899 into conda-forge:main Aug 6, 2024
3 checks passed
@henryiii
Copy link
Contributor

henryiii commented Aug 6, 2024

Okay, commented there. Nothing should be breaking.

@henryiii henryiii mentioned this pull request Aug 7, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge the PR when CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants