remove requiring boost 1.72 on windows #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svigerske
force-pushed
the
34-unpin-boost-cpp
branch
from
4ce188d
to
5f6365a
Compare
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipe/meta.yaml:
Documentation on acceptable licenses can be found here. |
svigerske
force-pushed
the
34-unpin-boost-cpp
branch
2 times, most recently
from
f2b0adb
to
dbd25c9
Compare
svigerske
force-pushed
the
34-unpin-boost-cpp
branch
from
1fa546a
to
3f47174
Compare
- not possible with current boost due to boostorg/serialization#232
- need to have libboost-devel in every host section, except zimpl, to get dependency on libboost in packages
svigerske
force-pushed
the
34-unpin-boost-cpp
branch
from
3f47174
to
852020f
Compare
|
@conda-forge-admin, please rerender |
…nda-forge-pinning 2024.11.09.10.10.20
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the windows builds to use current libboost-devel as well.
Due to boostorg/serialization#232, we cannot use current boost as header-only library on windows, so the corresponding flags that try to enable this in the CMakeLists.txt of soplex and papilo are removed by a patch.
Closes #34.
Checklist
0(if the version changed)conda-smithy(Use the phrase@conda-forge-admin, please rerenderin a comment in this PR for automated rerendering)