Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to v3.7.4, fix dependencies run tests on win,osx, linux64 #146

Merged
merged 9 commits into from
Jun 5, 2024

Conversation

rxm7706
Copy link
Contributor

@rxm7706 rxm7706 commented May 11, 2024

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

closes #145

  1. Adding a build dependence on {{ stdlib("c") }}
    This recipe is using a compiler, which now requires adding a build dependence on {{ stdlib("c") }} as well. For further details, please see META: {{ stdlib("c") }} migration conda-forge.github.io#2102.
  2. Updates host dependence on thinc >=8.1.8,<8.3.0
  3. Remove run requirement on pathy
  4. Disables tests on aarch64 and ppc64le
    Tests run slowly on ci servers, so we skip them in particular aarch64 and ppc64le take between 3 hrs to sometimes going over 6 hours and failing.
  5. Above changes upgrade the version to 3.7.4, and with arch limited tests - builds succeed and CI completes in <30 Mins, versus taking 5+ hours, and failing when timing out at 6 Hours.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@rxm7706
Copy link
Contributor Author

rxm7706 commented May 11, 2024

@conda-forge-admin, please rerender

@rxm7706 rxm7706 marked this pull request as ready for review May 12, 2024 00:23
@rxm7706
Copy link
Contributor Author

rxm7706 commented May 12, 2024

@conda-forge-admin, please rerender

@rxm7706 rxm7706 mentioned this pull request May 12, 2024
3 tasks
@rxm7706 rxm7706 changed the title Update to version 3.7.4 and fix dependencies Update to version 3.7.4, fix dependencies run tests on win,osx, linux64 May 12, 2024
@rxm7706 rxm7706 changed the title Update to version 3.7.4, fix dependencies run tests on win,osx, linux64 Update to v3.7.4, fix dependencies run tests on win,osx, linux64 May 12, 2024
@rxm7706
Copy link
Contributor Author

rxm7706 commented May 12, 2024

@adrianeboyd @honnibal @ines @rmax
Please review, I have update the description to call out all changes.
Thank you and regards.

@@ -35,7 +36,7 @@ requirements:
- murmurhash >=0.28.0,<1.1.0
- cymem >=2.0.2,<2.1.0
- preshed >=3.0.2,<3.1.0
- thinc >=8.1.8,<8.2.0
- thinc >=8.1.8,<8.3.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is going to be necessary for the python 3.12 migration (which is winding down), so it would be great to get this merged. :)

@h-vetinari
Copy link
Member

h-vetinari commented May 13, 2024

Hm, it appears that spacy uses tracing, which cython doesn't yet support for python 3.12. Let me revert my changes...

  spacy/matcher/levenshtein.c: In function '__pyx_f_5spacy_7matcher_11levenshtein_levenshtein':
  spacy/matcher/levenshtein.c:1177:32: error: '_PyCFrame' has no member named 'use_tracing'
   1177 |      (unlikely((tstate)->cframe->use_tracing) &&\
        |                                ^~

@rxm7706
Copy link
Contributor Author

rxm7706 commented Jun 5, 2024

@conda-forge-admin, please rerender

conda-forge-webservices[bot] and others added 2 commits June 5, 2024 10:36
@rxm7706
Copy link
Contributor Author

rxm7706 commented Jun 5, 2024

@conda-forge-admin, please rerender

@rxm7706
Copy link
Contributor Author

rxm7706 commented Jun 5, 2024

@adrianeboyd @honnibal @ines @rmax @h-vetinari
Could you please review and merge if this looks good.
Looks like spaCy 3.7.5 was released yesterday, I can work on a PR for it in parallel.
Thank you and regards.

@rmax
Copy link
Member

rmax commented Jun 5, 2024

Unblocking this, thanks!

@rmax rmax merged commit 0bb9f8d into conda-forge:main Jun 5, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants