Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use GitHub releases rather than archives #10251

Merged
merged 3 commits into from
Nov 27, 2019
Merged

Use GitHub releases rather than archives #10251

merged 3 commits into from
Nov 27, 2019

Conversation

jan-janssen
Copy link
Member

@jan-janssen jan-janssen commented Nov 21, 2019 •
edited
Loading

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I was trying to look for recipes to lint for you, but couldn't find any.
Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug.

@jan-janssen
Copy link
Member Author

@conda-forge/core Can you take a look at this?

@mbargull
Copy link
Member

IMHO, we should have both, releases as well as archive, in there.
We should tell people to prefer releases if they are available (they often are not!) and use archive if not.

mbargull
mbargull approved these changes Nov 21, 2019
View reviewed changes
Copy link
Member

@mbargull mbargull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@conda-forge/staged-recipes, feel free to merge if you are satisfied with the wording

@jan-janssen
Copy link
Member Author

@conda-forge/staged-recipes Can you merge this?

@scopatz scopatz merged commit 319232d into conda-forge:master Nov 27, 2019
@scopatz
Copy link
Member

scopatz commented Nov 27, 2019

Thanks @jan-janssen!

@jan-janssen jan-janssen deleted the patch-1 branch November 28, 2019 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbargull mbargull mbargull approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jan-janssen @conda-forge-linter @mbargull @scopatz @isuruf