Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dask-ms #11321

Merged
merged 12 commits into from
Apr 28, 2020
Merged

Add dask-ms #11321

Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
58e6e0e
initial version
sebastian-luna-valero Apr 17, 2020
f58b6d1
add license_family and restrictions on dependencies
sebastian-luna-valero Apr 20, 2020
5cefa2c
linting
sebastian-luna-valero Apr 20, 2020
49fa79e
add license field
sebastian-luna-valero Apr 20, 2020
26e1137
add @sjperkins as a maintainer
sebastian-luna-valero Apr 20, 2020
88b10c6
skip Windows builds
sebastian-luna-valero Apr 20, 2020
d8c4cd1
add import tests
sebastian-luna-valero Apr 20, 2020
fd70ea6
linting: remove noarch
sebastian-luna-valero Apr 20, 2020
bd97c29
change tests
sebastian-luna-valero Apr 20, 2020
410f400
bugfix test commands
sebastian-luna-valero Apr 20, 2020
8f2bf55
bugfix test commands
sebastian-luna-valero Apr 20, 2020
76656e3
package version 0.2.4
sebastian-luna-valero Apr 28, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 47 additions & 0 deletions recipes/dask-ms/meta.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,47 @@
{% set name = "dask-ms" %}
{% set version = "0.2.4" %}

package:
name: {{ name|lower }}
version: {{ version }}

source:
url: https://pypi.io/packages/source/{{ name[0] }}/{{ name }}/{{ name }}-{{ version }}.tar.gz
sha256: 31537be0fe0c7c82450336600a939d0538d59a670fc3fd4c00b093810226a48a

build:
skip: true # [win]
number: 0
script: "{{ PYTHON }} -m pip install . -vv"

requirements:
host:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think host can just include python and pip since the others are run and not build dependencies

- python
- pip
run:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The setup.py specifies version restrictions for several of the packages, so it is probably advisable to duplicate those restrictions here:

https://github.com/ska-sa/dask-ms/blob/master/setup.py

- python
- dask >=2.2.0
- numpy >=1.14.0
- python-casacore >=3.2.0
- xarray >0.12.0

test:
imports:
- daskms
commands:
- ${PYTHON} -c "from daskms import xds_from_ms"
- ${PYTHON} -c "from daskms import xds_from_table"
- ${PYTHON} -c "from daskms import xds_to_table"
- ${PYTHON} -c "from daskms import TableProxy"

about:
home: https://github.com/ska-sa/dask-ms
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a license field. It looks like a BSD-3-Clause (https://github.com/ska-sa/dask-ms/blob/master/LICENSE), but the setup.py meta says proprietary:

https://github.com/ska-sa/dask-ms/blob/master/setup.py#L45

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for reviewing the setup.py. I've updated it to reflect the BSD license in the pypi classifiers.

ratt-ru/dask-ms#104

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note this change will only reflect in the upcoming dask-ms 0.2.4.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks both. I will update this recipe accordingly to see whether it passes the tests.

I am also happy to wait for the 0.2.4 release before we merge.

license: BSD-3-Clause
license_family: BSD
license_file: LICENSE
summary: 'Implementation of a dask/xarray dataset backed by a CASA MS'

extra:
recipe-maintainers:
- sebastian-luna-valero
- sjperkins