-
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding ta-lib #12733
Adding ta-lib #12733
Conversation
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/libta-lib:
|
since the license file isn't in the unix tar.gz.
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
folder: unix # [unix] | ||
- url: https://downloads.sourceforge.net/project/ta-lib/ta-lib/0.4.0/ta-lib-0.4.0-msvc.zip | ||
sha256: 2dae7a1391222f0a7e601ecda654f93cebedfdb37afeb30df2721a3b0a717875 | ||
folder: win |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The LICENSE file is only found in the windows zip, so I'm downloading it in all cases to find that.
extra: | ||
recipe-maintainers: | ||
- gerrymanoim | ||
- llllllllll |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gerrymanoim @llllllllll - are you OK with being maintainers?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep - sorry missed this. All good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am.
Thanks! |
Hi @conda-forge/help-python-c
My goal here is to add a package for the ta-lib python wrapper for the TA-Lib c/c++ library, essentially porting the recipe we've had here to conda-forge.
My thought was to split the c lib into its own package now ("libta-lib"), whereas our original recipe in the zipline repo inlines that installation in the wrapper package. Any recommendations on this? I believe this necessitates
run_exports
, but feedback would be most appreciated.Checklist
url
) rather than a repo (e.g.git_url
) is used in your recipe (see here for more details)