Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding ta-lib #12733

Merged
merged 4 commits into from
Sep 29, 2020
Merged

Adding ta-lib #12733

merged 4 commits into from
Sep 29, 2020

Conversation

richafrank
Copy link
Contributor

@richafrank richafrank commented Sep 25, 2020

Hi @conda-forge/help-python-c

My goal here is to add a package for the ta-lib python wrapper for the TA-Lib c/c++ library, essentially porting the recipe we've had here to conda-forge.

My thought was to split the c lib into its own package now ("libta-lib"), whereas our original recipe in the zipline repo inlines that installation in the wrapper package. Any recommendations on this? I believe this necessitates run_exports, but feedback would be most appreciated.

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml"
  • License file is packaged (see here for an example)
  • Source is from official source
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged)
  • If static libraries are linked in, the license of the static library is packaged.
  • Build number is 0
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details)
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/libta-lib, recipes/ta-lib) and found some lint.

Here's what I've got...

For recipes/libta-lib:

  • Selectors are suggested to take a <two spaces>#<one space>[<expression>] form. See lines [9]

since the license file isn't in the unix tar.gz.
@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/libta-lib, recipes/ta-lib) and found it was in an excellent condition.

folder: unix # [unix]
- url: https://downloads.sourceforge.net/project/ta-lib/ta-lib/0.4.0/ta-lib-0.4.0-msvc.zip
sha256: 2dae7a1391222f0a7e601ecda654f93cebedfdb37afeb30df2721a3b0a717875
folder: win
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The LICENSE file is only found in the windows zip, so I'm downloading it in all cases to find that.

extra:
recipe-maintainers:
- gerrymanoim
- llllllllll
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gerrymanoim @llllllllll - are you OK with being maintainers?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep - sorry missed this. All good.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am.

@scopatz scopatz merged commit 77d03cf into conda-forge:master Sep 29, 2020
@scopatz
Copy link
Member

scopatz commented Sep 29, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants