Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create an initial catalystcoop.dbfread packaging recipe #12902

Merged
merged 4 commits into from
Oct 16, 2020

Conversation

zaneselvans
Copy link
Contributor

@zaneselvans zaneselvans commented Oct 15, 2020

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml"
  • License file is packaged (see here for an example)
  • Source is from official source
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged)
  • Build number is 0
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details)
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there

@zaneselvans
Copy link
Contributor Author

Happy to be listed as maintainer.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/catalystcoop.dbfread) and found some lint.

Here's what I've got...

For recipes/catalystcoop.dbfread:

  • Selectors are suggested to take a <two spaces>#<one space>[<expression>] form. See lines [15]
  • There are 1 too many lines. There should be one empty line at the end of the file.
  • noarch packages can't have selectors. If the selectors are necessary, please remove noarch: python.

recipes/catalystcoop.dbfread/meta.yaml Outdated Show resolved Hide resolved
@@ -1,21 +0,0 @@
The MIT License
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You shouldn't have to delete the files for catalystcoop.pudl since the CI during merge will take care of this.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/catalystcoop.dbfread) and found some lint.

Here's what I've got...

For recipes/catalystcoop.dbfread:

  • There are 1 too many lines. There should be one empty line at the end of the file.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/catalystcoop.dbfread) and found it was in an excellent condition.

@zaneselvans
Copy link
Contributor Author

zaneselvans commented Oct 15, 2020

@conda-forge/help-python The tests are failing on Windows, I believe it's because there's a command line utility called dbf2sqlite which is deployed on installation of the package, and I'm attempting to execute it via the test commands section of the meta.yaml:

test:
  imports:
    - dbfread
  source_files:
    - tests/
    - testcases/
  requires:
    - zipp
    - pytest
  commands:
    - pytest tests
    - dbf2sqlite --help

to ensure that it's runnable, as suggested in the documentation for contributing a package. But this seems to be generating this error:

'dbf2sqlite' is not recognized as an internal or external command,

The script appears to execute just fine on the Linux and OS X platforms. Is there an appropriate way to try and call a deployed python script on Windows? Or if not, to just skip that command on Windows?

@zaneselvans
Copy link
Contributor Author

@synapticarbors Do you have any pointers on getting the included command line utility to execute in the tests on Windows? I haven't been able to find a similar example in other feedstocks or the documentation. It's installed using the scripts keyword in setup.py not console_scripts / entrypoints. Not sure if that matters.

@synapticarbors
Copy link
Member

@zaneselvans -- since this is noarch: python and will only be actually built on linux, it may be ok to ignore this, but I'm not 100% sure. I'm not going to be able to look at this issue for a bit, so I'm going to ping @conda-forge/staged-recipes to see if someone else has a definitive answer concerning a command line utility built from setup.py's scripts option (vs an entry point) failing on windows.

@ocefpaf
Copy link
Member

ocefpaf commented Oct 16, 2020

The problem on Windows is the exit code:

IF 9009 NEQ 0 exit /B 1

That is usually fine b/c on Windows sometimes a successful does not really returns 0.

@ocefpaf ocefpaf merged commit 2e40c76 into conda-forge:master Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants