-
-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create an initial catalystcoop.dbfread packaging recipe #12902
Conversation
Happy to be listed as maintainer. |
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/catalystcoop.dbfread:
|
@@ -1,21 +0,0 @@ | |||
The MIT License |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You shouldn't have to delete the files for catalystcoop.pudl
since the CI during merge will take care of this.
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/catalystcoop.dbfread:
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge/help-python The tests are failing on Windows, I believe it's because there's a command line utility called test:
imports:
- dbfread
source_files:
- tests/
- testcases/
requires:
- zipp
- pytest
commands:
- pytest tests
- dbf2sqlite --help to ensure that it's runnable, as suggested in the documentation for contributing a package. But this seems to be generating this error:
The script appears to execute just fine on the Linux and OS X platforms. Is there an appropriate way to try and call a deployed python script on Windows? Or if not, to just skip that command on Windows? |
@synapticarbors Do you have any pointers on getting the included command line utility to execute in the tests on Windows? I haven't been able to find a similar example in other feedstocks or the documentation. It's installed using the |
@zaneselvans -- since this is |
The problem on Windows is the exit code:
That is usually fine b/c on Windows sometimes a successful does not really returns |
Checklist
url
) rather than a repo (e.g.git_url
) is used in your recipe (see here for more details)