Added pandasgui package #13237

adamerose · 2020-11-15T08:36:15Z

Checklist

[✓] Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml"
[✓] License file is packaged (see here for an example)
[✓] Source is from official source
[✓] Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged)
[✓] If static libraries are linked in, the license of the static library is packaged.
[✓] Build number is 0
[✓] A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details)
[✓] GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there

conda-forge-linter · 2020-11-15T08:36:21Z

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/pandasgui) and found some lint.

Here's what I've got...

For recipes/pandasgui:

Please do not delete the example recipe found in recipes/example/meta.yaml.

For recipes/pandasgui:

noarch: python recipes are recommended to have a lower bound on the python version. This recommendation will become a requirement in the future.

conda-forge-linter · 2020-11-15T08:57:19Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/pandasgui) and found it was in an excellent condition.

…o 5*.

…equirements for linux.

conda-forge-linter · 2020-11-16T14:27:20Z

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/pandasgui) and found some lint.

Here's what I've got...

For recipes/pandasgui:

noarch packages can't have selectors. If the selectors are necessary, please remove noarch: python.

conda-forge-linter · 2020-11-16T14:37:17Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/pandasgui) and found it was in an excellent condition.

danschef · 2020-11-16T14:47:11Z

@ocefpaf @mingwandroid I ping you here as we seem to have a similar problem to this one here. The build process fails for Linux with ImportError: libGL.so.1: cannot open shared object file: No such file or directory. I already tried to add libgl1-mesa-glx to the host requirements in case of Linux but it does not seem to work. Maybe I did not use the right syntax there.

Do you have any suggestion what is wrong with this recipe? The OSX build also fails with another error but I guess this does not matter in case of a noarch package.

ocefpaf · 2020-11-16T14:52:57Z

@danschef please take a look at https://conda-forge.org/docs/maintainer/knowledge_base.html#libgl

…t libGL.

danschef · 2020-11-16T15:15:49Z

Thanks , I updated the recipe accordingly (looks like we can't build it as a noarch package anymore) which fixes the ImportError: libGL.so.1 . However, some lines further pandasgui runs from PyQt5 import QtWebEngineWidgets which fails with another missing library in the Linux build:

import: 'pandasgui'
Traceback (most recent call last):
  File "/home/conda/staged-recipes/build_artifacts/pandasgui_1605539216465/test_tmp/run_test.py", line 2, in <module>
    import pandasgui
  File "/home/conda/staged-recipes/build_artifacts/pandasgui_1605539216465/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placeh/lib/python3.8/site-packages/pandasgui/__init__.py", line 1, in <module>
    from pandasgui.gui import show
  File "/home/conda/staged-recipes/build_artifacts/pandasgui_1605539216465/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placeh/lib/python3.8/site-packages/pandasgui/gui.py", line 14, in <module>
    from pandasgui.widgets.dataframe_explorer import DataFrameExplorer
  File "/home/conda/staged-recipes/build_artifacts/pandasgui_1605539216465/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placeh/lib/python3.8/site-packages/pandasgui/widgets/dataframe_explorer.py", line 9, in <module>
    from pandasgui.widgets.grapher import Grapher
  File "/home/conda/staged-recipes/build_artifacts/pandasgui_1605539216465/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placeh/lib/python3.8/site-packages/pandasgui/widgets/grapher.py", line 16, in <module>
    from pandasgui.widgets.plotly_viewer import PlotlyViewer
  File "/home/conda/staged-recipes/build_artifacts/pandasgui_1605539216465/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placeh/lib/python3.8/site-packages/pandasgui/widgets/plotly_viewer.py", line 32, in <module>
    raise e
  File "/home/conda/staged-recipes/build_artifacts/pandasgui_1605539216465/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placeh/lib/python3.8/site-packages/pandasgui/widgets/plotly_viewer.py", line 20, in <module>
    from PyQt5 import QtWebEngineWidgets
ImportError: libXcomposite.so.1: cannot open shared object file: No such file or directory

ocefpaf · 2020-11-16T15:47:14Z

recipes/pandasgui/meta.yaml

+    - {{ cdt('libselinux') }}  # [linux]
+    - {{ cdt('libxdamage') }}  # [linux]
+    - {{ cdt('libxxf86vm') }}  # [linux]
+    - {{ cdt('libxext') }}     # [linux]


You can still be noarch and you probably don't need all of them. Please try adding only the yum requirements with mesa-libGL first.

Ok, so I can safely remove the selectors in the complete recipe to make it noarch?

Let's try first without the CDTs, if we can fix this with only the yum requirements we can make Linux GUI happy and macOS and Windows can probably use the same noarch package. If we really need the CDTs we may need to drop the noarch.

Ok, I did not convert it back to noarch, yet, but I removed the CDT packages you mentioned in #13237 (comment) and the libGL error does not show up again. So, they are obviously not needed.

However, there is still the ImportError: libXcomposite.so.1. According to this, a sudo apt-get install python-pyqt5.qtwebkit might help. But where do I have to add it?

Adding python-pyqt5.qtwebkit to the host requirements to fix the ImportError: libXcomposite.so.1 does not seem to work. Do I need to use a different package name?

danschef · 2020-11-19T17:29:46Z

@conda-forge/staged-recipes
I think we need some assistance here. The Linux build still fails with ImportError: libXcomposite.so.1 when importing QtWebEngineWidgets from PyQt5. So far, I could not find a solution (see above).

jakirkham · 2020-11-19T17:55:53Z

recipes/pandasgui/meta.yaml

+    - pandasgui.widgets
+  commands:
+    - pip check
+  requires:


Would add the same CDTs from build above here.

@jakirkham @ocefpaf
Done, but without success.

Any advice on how to proceed?

@conda-forge/staged-recipes

Sorry. Out of ideas. I can try a few things later this week but I cannot promise I'll have time for it.

That would be very helpful, thanks!

…est requirements.

ocefpaf · 2021-01-27T18:00:37Z

@adamerose you'll probably need https://github.com/conda-forge/pyqt-feedstock/blob/master/recipe/xcrun and https://github.com/conda-forge/pyqt-feedstock/blob/master/recipe/xcodebuild on macOS.

ocefpaf · 2021-01-27T18:01:44Z

Also, if you want to skip Windows and macOS for now, get this merged for Linux, we can fix the rest on the feedstock.

danschef · 2021-01-27T20:41:44Z

@ocefpaf Thanks a lot for looking into this! I would also suggest to merge this now and fix the rest on the feedstock. The recipe build seems to work fine on Linux and Windows, so only OSX is missing.
@adamrose If you like, I would offer to be a maintainer of the feedstock. Maybe I can support you there a bit.

ocefpaf · 2021-01-27T20:52:09Z

@ocefpaf Thanks a lot for looking into this! I would also suggest to merge this now and fix the rest on the feedstock. The recipe build seems to work fine on Linux and Windows, so only OSX is missing.
@adamrose If you like, I would offer to be a maintainer of the feedstock. Maybe I can support you there a bit.

Great, let's address the remaining issues on the feedstock. Apologies for the delay to get to this one but lately I've been fighting against my GH notifications a lot 😄

adamerose · 2021-01-27T21:22:32Z

Thanks everyone! @danschef I added you to the maintainers list, would be great to have help since I'm new to using conda-forge.

Added pandasgui package

021d6bc

adamerose added 2 commits November 15, 2020 03:43

Undo example/meta.yaml deletion

d65c8c2

Specify lower bound Python version

5dc0ba1

Fix python versioning

d000836

adamerose mentioned this pull request Nov 15, 2020

Release pandasgui on conda-forge adamerose/PandasGUI#51

Open

danschef added 3 commits November 16, 2020 11:44

Merge branch 'master' of https://github.com/conda-forge/staged-recipes

e737d87

Added sip and removed setuptools from run requirements. Pinned pyqt t…

0067e57

…o 5*.

Removed sip from run requirements and added libgl1-mesa-glx to host r…

d85e42e

…equirements for linux.

Removed libgl1-mesa-glx.

96d191f

Try to fix Linux build by adding CDT packages to properly link agains…

267de49

…t libGL.

ocefpaf reviewed Nov 16, 2020

View reviewed changes

danschef added 2 commits November 16, 2020 16:58

Removed probably not needed CDT packages.

dcd53d7

Added python-pyqt5.qtwebkit to host requirements.

0fa98c0

jakirkham reviewed Nov 19, 2020

View reviewed changes

danschef added 3 commits November 19, 2020 19:18

Removed python-pyqt5.qtwebkit from host requirements. Added CDTs to t…

78a7368

…est requirements.

Removed python-pyqt5.qtwebkit from host requirements.

555ae45

Merge branch 'master' of https://github.com/conda-forge/staged-recipes

e6a79ed

ickc mentioned this pull request Dec 12, 2020

Add pandasgui #13458

Closed

9 tasks

ocefpaf added 3 commits January 27, 2021 14:36

test

dd8c387

copy the pyqt one

8c4ba24

Update meta.yaml

bdfe35f

ocefpaf merged commit 95342c2 into conda-forge:master Jan 27, 2021

danschef mentioned this pull request Jan 27, 2021

Recipe build fails on OSX. conda-forge/pandasgui-feedstock#1

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added pandasgui package #13237

Added pandasgui package #13237

adamerose commented Nov 15, 2020

conda-forge-linter commented Nov 15, 2020

conda-forge-linter commented Nov 15, 2020

conda-forge-linter commented Nov 16, 2020

conda-forge-linter commented Nov 16, 2020

danschef commented Nov 16, 2020 •

edited

Loading

ocefpaf commented Nov 16, 2020

danschef commented Nov 16, 2020 •

edited

Loading

ocefpaf Nov 16, 2020

danschef Nov 16, 2020

ocefpaf Nov 16, 2020

danschef Nov 16, 2020

danschef Nov 17, 2020

danschef commented Nov 19, 2020 •

edited

Loading

jakirkham Nov 19, 2020

danschef Nov 19, 2020

adamerose Dec 1, 2020

danschef Dec 7, 2020

ocefpaf Dec 7, 2020

danschef Dec 7, 2020

ocefpaf commented Jan 27, 2021

ocefpaf commented Jan 27, 2021

danschef commented Jan 27, 2021

ocefpaf commented Jan 27, 2021

adamerose commented Jan 27, 2021

Added pandasgui package #13237

Added pandasgui package #13237

Conversation

adamerose commented Nov 15, 2020

conda-forge-linter commented Nov 15, 2020

conda-forge-linter commented Nov 15, 2020

conda-forge-linter commented Nov 16, 2020

conda-forge-linter commented Nov 16, 2020

danschef commented Nov 16, 2020 • edited Loading

ocefpaf commented Nov 16, 2020

danschef commented Nov 16, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

danschef commented Nov 19, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ocefpaf commented Jan 27, 2021

ocefpaf commented Jan 27, 2021

danschef commented Jan 27, 2021

ocefpaf commented Jan 27, 2021

adamerose commented Jan 27, 2021

danschef commented Nov 16, 2020 •

edited

Loading

danschef commented Nov 16, 2020 •

edited

Loading

danschef commented Nov 19, 2020 •

edited

Loading