Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add systemd (libsystemd and libudev outputs only!) #16062

Merged
merged 1 commit into from
Sep 17, 2021

Conversation

ryanvolz
Copy link
Contributor

@ryanvolz ryanvolz commented Sep 3, 2021

This adds a proper conda package for libudev (and libsystemd just because), which is desirable over the current state of using a CDT because of conda-forge/cdt-builds#48 and the general headaches that come with depending on CDTs (e.g. conda-forge/libusb-feedstock#15). I've tested this locally with a rebuild of libusb, and it appears to work.

This builds with no patches for the CentOS 7 base environment, and I think it's probably sufficient to leave it at that and continue to use the libudev CDT for cos6. Judging from the previous packaging attempt, it should be possible to patch this up to work with the older glibc and kernel versions used with CentOS 6 should that be desired.


Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/systemd) and found it was in an excellent condition.

@ryanvolz ryanvolz marked this pull request as ready for review September 3, 2021 17:58
@ryanvolz
Copy link
Contributor Author

ryanvolz commented Sep 3, 2021

@conda-forge/staged-recipes Ready for review. This one could probably use some extra careful eyes.

@chrisburr chrisburr merged commit 4d125ca into conda-forge:main Sep 17, 2021
@ryanvolz ryanvolz deleted the systemd branch September 17, 2021 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants