Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding recipes for magic #18295

Merged
merged 1 commit into from
May 25, 2022
Merged

Adding recipes for magic #18295

merged 1 commit into from
May 25, 2022

Conversation

proppy
Copy link
Contributor

@proppy proppy commented Mar 11, 2022 •
edited
Loading

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • ⚠️ open_pdks does vendor other sub packages (either as submodules or by downloading them as part of the build process) but the licenses of all packages is packaged in about/license_file.
  • If static libraries are linked in, the license of the static library is packaged.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

Notes

This is a subset of the packages from https://github.com/hdl/conda-eda/.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/magic, recipes/netgen, recipes/open_pdks, recipes/openroad) and found some lint.

Here's what I've got...

For recipes/magic:

  • When defining a source/url please add a sha256, sha1 or md5 checksum (sha256 preferably).
  • requirements: host: python>=3.7 must contain a space between the name and the pin, i.e. python >=3.7
  • requirements: run: python>=3.7 must contain a space between the name and the pin, i.e. python >=3.7

For recipes/netgen:

  • When defining a source/url please add a sha256, sha1 or md5 checksum (sha256 preferably).
  • Feedstock with the same name exists in conda-forge.

For recipes/open_pdks:

  • When defining a source/url please add a sha256, sha1 or md5 checksum (sha256 preferably).
  • When defining a source/url please add a sha256, sha1 or md5 checksum (sha256 preferably).
  • When defining a source/url please add a sha256, sha1 or md5 checksum (sha256 preferably).
  • When defining a source/url please add a sha256, sha1 or md5 checksum (sha256 preferably).
  • When defining a source/url please add a sha256, sha1 or md5 checksum (sha256 preferably).
  • When defining a source/url please add a sha256, sha1 or md5 checksum (sha256 preferably).
  • license_file entry is missing, but is required.

For recipes/openroad:

  • When defining a source/url please add a sha256, sha1 or md5 checksum (sha256 preferably).
  • If python is a host requirement, it should be a run requirement.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/magic, recipes/netgen, recipes/open_pdks, recipes/openroad) and found some lint.

Here's what I've got...

For recipes/magic:

  • When defining a source/url please add a sha256, sha1 or md5 checksum (sha256 preferably).
  • Non noarch packages should have python requirement without any version constraints.
  • Non noarch packages should have python requirement without any version constraints.

For recipes/netgen:

  • When defining a source/url please add a sha256, sha1 or md5 checksum (sha256 preferably).

For recipes/open_pdks:

  • When defining a source/url please add a sha256, sha1 or md5 checksum (sha256 preferably).
  • When defining a source/url please add a sha256, sha1 or md5 checksum (sha256 preferably).
  • When defining a source/url please add a sha256, sha1 or md5 checksum (sha256 preferably).
  • When defining a source/url please add a sha256, sha1 or md5 checksum (sha256 preferably).
  • When defining a source/url please add a sha256, sha1 or md5 checksum (sha256 preferably).
  • When defining a source/url please add a sha256, sha1 or md5 checksum (sha256 preferably).

For recipes/openroad:

  • When defining a source/url please add a sha256, sha1 or md5 checksum (sha256 preferably).
  • If python is a host requirement, it should be a run requirement.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/magic, recipes/netgen, recipes/open_pdks, recipes/openroad) and found some lint.

Here's what I've got...

For recipes/magic:

  • When defining a source/url please add a sha256, sha1 or md5 checksum (sha256 preferably).

For recipes/netgen:

  • When defining a source/url please add a sha256, sha1 or md5 checksum (sha256 preferably).

For recipes/open_pdks:

  • When defining a source/url please add a sha256, sha1 or md5 checksum (sha256 preferably).
  • When defining a source/url please add a sha256, sha1 or md5 checksum (sha256 preferably).
  • When defining a source/url please add a sha256, sha1 or md5 checksum (sha256 preferably).
  • When defining a source/url please add a sha256, sha1 or md5 checksum (sha256 preferably).
  • When defining a source/url please add a sha256, sha1 or md5 checksum (sha256 preferably).
  • When defining a source/url please add a sha256, sha1 or md5 checksum (sha256 preferably).

For recipes/openroad:

  • When defining a source/url please add a sha256, sha1 or md5 checksum (sha256 preferably).
  • If python is a host requirement, it should be a run requirement.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/magic, recipes/netgen, recipes/open_pdks, recipes/openroad) and found some lint.

Here's what I've got...

For recipes/magic:

  • When defining a source/url please add a sha256, sha1 or md5 checksum (sha256 preferably).

For recipes/netgen:

  • When defining a source/url please add a sha256, sha1 or md5 checksum (sha256 preferably).

For recipes/open_pdks:

  • When defining a source/url please add a sha256, sha1 or md5 checksum (sha256 preferably).
  • When defining a source/url please add a sha256, sha1 or md5 checksum (sha256 preferably).
  • When defining a source/url please add a sha256, sha1 or md5 checksum (sha256 preferably).
  • When defining a source/url please add a sha256, sha1 or md5 checksum (sha256 preferably).
  • When defining a source/url please add a sha256, sha1 or md5 checksum (sha256 preferably).
  • When defining a source/url please add a sha256, sha1 or md5 checksum (sha256 preferably).

For recipes/openroad:

  • When defining a source/url please add a sha256, sha1 or md5 checksum (sha256 preferably).

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/magic, recipes/netgen, recipes/open_pdks) and found it was in an excellent condition.

@proppy proppy mentioned this pull request Mar 11, 2022
Open
@proppy proppy changed the title Adding recipes for conda-eda packages Adding recipes for open_pdks Mar 11, 2022
@proppy proppy changed the title Adding recipes for open_pdks Adding recipes for open_pdks and magic Mar 11, 2022
@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/magic, recipes/open_pdks) and found it was in an excellent condition.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/magic, recipes/open_pdks) and found some lint.

Here's what I've got...

For recipes/open_pdks:

  • noarch packages can't have selectors. If the selectors are necessary, please remove noarch: generic.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/magic, recipes/open_pdks) and found it was in an excellent condition.

@proppy proppy mentioned this pull request Mar 15, 2022
Open
@curtisma
Copy link
Contributor

curtisma commented Mar 20, 2022 •
edited
Loading

Since these are Linux-only you should be able to setup the meta.yml to skip non-linux builds. This can be done using the "build skip" entry and pre-processing selectors.
See the conda-forge docs.

build:
    skip: true  # [not linux64]

@proppy

@curtisma
Copy link
Contributor

curtisma commented Mar 20, 2022 •
edited
Loading

Feel free to add me as a maintainer also.
@proppy

@proppy
Copy link
Contributor Author

proppy commented Mar 22, 2022 •
edited
Loading

Since these are Linux-only you should be able to setup the meta.yml to skip non-linux builds. This can be done using the "build skip" entry and pre-processing selectors.

I tried to do that for the open_pdks package but @conda-forge-linter complained because it was a noarch package.

We already have a skip: true [win] selector for the magic package and it seems it's close to building on osx https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=476156&view=logs&j=e35d4f76-8ff2-5536-d795-df91e63eb9f7&t=fa7b4b17-b6ff-5c9c-8cfc-15f888c92310&l=3483 (it only fails on make install) so I'd be tempted to investigate and fix it as part of this PR, wdyt?

@proppy
Copy link
Contributor Author

proppy commented Mar 29, 2022

@conda-forge/staged-recipes I think this is ready for you to review, let me know if you'd prefer to have them be submitted separately (note: we are also planning to stage packages for openroad and netgen that were initially included in this PR).

@proppy
Copy link
Contributor Author

proppy commented Mar 29, 2022

@conda-forge-admin, please ping team :)

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-webservice.

I was asked to ping @conda-forge/staged-recipes and so here I am doing that.

proppy
proppy commented Mar 29, 2022
View reviewed changes
recipes/magic/meta.yaml Outdated
However, it is the well thought-out core algorithms which lend to magic the greatest part of its popularity.
Magic is widely cited as being the easiest tool to use for circuit layout, even for people who ultimately rely on commercial tools for their product design flow.
doc_url: http://opencircuitdesign.com/magic/magic_docs.html
dev_url: https://github.com/RTimothyEdwards/netgen
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be https://github.com/RTimothyEdwards/magic

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I was trying to look for recipes to lint for you, but couldn't find any.
Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/magic, recipes/open_pdks) and found it was in an excellent condition.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I was trying to look for recipes to lint for you, but couldn't find any.
Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug.

@proppy proppy changed the title Adding recipes for open_pdks and magic Adding recipes for magic May 25, 2022
@proppy
Copy link
Contributor Author

proppy commented May 25, 2022

PTAL, updated the PR to only add magic for now to ease review/submission.

@proppy
Copy link
Contributor Author

proppy commented May 25, 2022

@conda-forge-admin, please ping team :)

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-webservice.

I was asked to ping @conda-forge/staged-recipes and so here I am doing that.

@ocefpaf ocefpaf merged commit 356efa9 into conda-forge:main May 25, 2022
@proppy
Copy link
Contributor Author

proppy commented May 25, 2022

Thanks for the quick review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ocefpaf ocefpaf ocefpaf left review comments

Assignees
No one assigned
Labels
review-requested staged-recipes
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@proppy @conda-forge-linter @curtisma @ocefpaf