Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add recipe for meson-python #19033

Merged
merged 1 commit into from
Jun 2, 2022
Merged

Add recipe for meson-python #19033

merged 1 commit into from
Jun 2, 2022

Conversation

awvwgk
Copy link
Member

@awvwgk awvwgk commented May 20, 2022

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/meson-python) and found some lint.

Here's what I've got...

For recipes/meson-python:

  • The top level meta keys are in an unexpected order. Expecting ['package', 'source', 'build', 'requirements', 'test', 'about', 'extra'].

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/meson-python) and found it was in an excellent condition.

@awvwgk awvwgk force-pushed the meson-python branch 5 times, most recently from 857888e to 989ad51 Compare May 20, 2022 21:43
@awvwgk
Copy link
Member Author

awvwgk commented May 20, 2022

@conda-forge/help-python This recipe is ready for review. While I would prefer noarch: python, it seems more important to support all Python versions to not limit other Python packages planning to use this one as build system (like SciPy).

Copy link

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this @awvwgk!

The patch here looks wrong to me. If there's something to fix, let's do it upstream. But the reason for changing ninja requirements here is not correct either way: when one uses build isolation in a Python venv, a ninja installed by conda-forge cannot be used.

This package should be noarch. The pip check failure may be due to incorrect metadata in pyproject.toml; if needed a patch can be carried for that until it's fixed in the next meson-python release.

@awvwgk awvwgk force-pushed the meson-python branch 3 times, most recently from cf4bc5e to eb61bfb Compare May 22, 2022 15:14
@awvwgk awvwgk force-pushed the meson-python branch 4 times, most recently from 91f7e94 to 5331f3b Compare May 22, 2022 17:16
@awvwgk
Copy link
Member Author

awvwgk commented May 22, 2022

Seems like this is ready for review again, now as noarch: python.

Copy link

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall now, thanks @awvwgk

recipes/meson-python/meta.yaml Show resolved Hide resolved
recipes/meson-python/ninja-overdep.patch Show resolved Hide resolved
@awvwgk awvwgk force-pushed the meson-python branch 3 times, most recently from 5e4f7bc to d4cdbdf Compare May 26, 2022 15:13
Copy link

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@rgommers
Copy link

rgommers commented Jun 2, 2022

@conda-forge/staged-recipes can this be merged?

@xhochy xhochy merged commit f4c2896 into conda-forge:main Jun 2, 2022
@weiji14 weiji14 mentioned this pull request Jun 5, 2022
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

6 participants