-
-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add recipe for meson-python #19033
Add recipe for meson-python #19033
Conversation
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/meson-python:
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
857888e
to
989ad51
Compare
@conda-forge/help-python This recipe is ready for review. While I would prefer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this @awvwgk!
The patch here looks wrong to me. If there's something to fix, let's do it upstream. But the reason for changing ninja
requirements here is not correct either way: when one uses build isolation in a Python venv, a ninja
installed by conda-forge cannot be used.
This package should be noarch
. The pip check
failure may be due to incorrect metadata in pyproject.toml
; if needed a patch can be carried for that until it's fixed in the next meson-python
release.
cf4bc5e
to
eb61bfb
Compare
91f7e94
to
5331f3b
Compare
Seems like this is ready for review again, now as |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall now, thanks @awvwgk
5e4f7bc
to
d4cdbdf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
@conda-forge/staged-recipes can this be merged? |
Checklist
url
) rather than a repo (e.g.git_url
) is used in your recipe (see here for more details).