Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add autoboost #19895

Merged
merged 3 commits into from
Nov 21, 2022
Merged

add autoboost #19895

merged 3 commits into from
Nov 21, 2022

Conversation

gieses
Copy link
Contributor

@gieses gieses commented Aug 1, 2022

This repository is very active, so if you need help with a PR, please let the
right people know. There are language-specific teams for reviewing recipes.

Language Name of review team
python @conda-forge/help-python
python/c hybrid @conda-forge/help-python-c
r @conda-forge/help-r
java @conda-forge/help-java
nodejs @conda-forge/help-nodejs
c/c++ @conda-forge/help-c-cpp
perl @conda-forge/help-perl
Julia @conda-forge/help-julia
ruby @conda-forge/help-ruby
other @conda-forge/staged-recipes

Once the PR is ready for review, please mention one of the teams above in a
new comment. i.e. @conda-forge/help-some-language, ready for review!
Then, a bot will label the PR as 'review-requested'.

Due to GitHub limitations, first time contributors to conda-forge are unable
to ping conda-forge teams directly, but you can ask a bot to ping the team
using a special command in a comment on the PR to get the attention of the
staged-recipes team. You can also consider asking on our Gitter channel
if your recipe isn't reviewed promptly.

-->

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • [x ] License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/autoboost) and found some lint.

Here's what I've got...

For recipes/autoboost:

  • If python is a host requirement, it should be a run requirement.
  • Non noarch packages should have python requirement without any version constraints.

For recipes/autoboost:

  • Recipes should usually depend on matplotlib-base as opposed to matplotlib so that runtime environments do not require large packages like qt.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/autoboost) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipes/autoboost:

  • Recipes should usually depend on matplotlib-base as opposed to matplotlib so that runtime environments do not require large packages like qt.

@gieses
Copy link
Contributor Author

gieses commented Aug 1, 2022

@conda-forge/help-python, ready for review!

@conda-forge-admin , please ping team

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-webservice.

I was asked to ping @conda-forge/staged-recipes and so here I am doing that.

@BastianZim
Copy link
Member

Recipes should usually depend on matplotlib-base as opposed to matplotlib so that runtime environments do not require large packages like qt.

Have you checked if this can be the case?

- pip
run:
- python >=3.9
- matplotlib
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does look like this package requires qt. This would reduce the size of the installation drastically and it is highly recommended.

Suggested change
- matplotlib
- matplotlib-base

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I tried this before but it was failing. I will validate this and update the version.
Cheers!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ocefpaf interestingly, now it worked with the base package.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/autoboost) and found it was in an excellent condition.

@ocefpaf ocefpaf merged commit 91dede4 into conda-forge:main Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

5 participants