Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add supabase client #20886

Merged
merged 8 commits into from
Nov 20, 2022
Merged

add supabase client #20886

merged 8 commits into from
Nov 20, 2022

Conversation

timkpaine
Copy link
Member

@timkpaine timkpaine commented Oct 25, 2022

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/gotrue, recipes/postgrest, recipes/realtime, recipes/storage3, recipes/supabase, recipes/supafunc) and found it was in an excellent condition.

@timkpaine
Copy link
Member Author

@conda-forge/help-python all set, had to disable some pip check due to some upstream dep issues which im looking into

@timkpaine
Copy link
Member Author

@anand2312 @dreinon @J0 @leynier anybody want to be a maintainer here?

@J0
Copy link

J0 commented Oct 26, 2022

Hey @timkpaine,

Thanks for putting this PR together! Would be great to have conda support - feel free to add me as a maintainer. Let me also ping the rest of the maintainers to see if they want to hop onboard.

@anand2312
Copy link

Thanks! Feel free to add me too if necessary

@timkpaine
Copy link
Member Author

timkpaine commented Oct 27, 2022

@conda-forge/help-python ok now actually all set

@timkpaine
Copy link
Member Author

@conda-forge/help-python just checking in if theres any changes i should make

recipes/supabase/meta.yaml Show resolved Hide resolved
recipes/realtime/meta.yaml Show resolved Hide resolved
recipes/postgrest/meta.yaml Show resolved Hide resolved
@timkpaine
Copy link
Member Author

timkpaine commented Nov 20, 2022

@conda-forge/help-python all set, had to disable some pip check due to some upstream dep issues which im looking into

@xhochy note comment about pip check. the results of pip check are wrong for realtime since it specifies "dataclasses" as a dep regardless of python version and dataclasses does not install post py36 (I validated this manually) so the check is omitted, then it is again omitted for supabase since realtime is a dep.

this commit (supabase/realtime-py@cdb7570) fixes it, so it will be picked up (and pip check readded) in a future release

@xhochy
Copy link
Member

xhochy commented Nov 20, 2022

I would normally request a comment on why it has been omitted but with a merged upstream fix, I'm fine.

@xhochy xhochy merged commit 811d46c into conda-forge:main Nov 20, 2022
@timkpaine timkpaine deleted the tkp/supabase branch November 20, 2022 20:21
@timkpaine
Copy link
Member Author

I would normally request a comment on why it has been omitted but with a merged upstream fix, I'm fine.

if you have dataclasses as an unscoped dep pip check will fail. You need something like dataclasses; python<3.7 for it to pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

5 participants