Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add libnvjpeg recipe #22128

Merged
merged 14 commits into from
Apr 15, 2023
Merged

Add libnvjpeg recipe #22128

merged 14 commits into from
Apr 15, 2023

Conversation

adibbley
Copy link
Contributor

@adibbley adibbley commented Feb 23, 2023

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/libnvjpeg) and found it was in an excellent condition.

@adibbley
Copy link
Contributor Author

cc @jakirkham

recipes/libnvjpeg/meta.yaml Show resolved Hide resolved
recipes/libnvjpeg/meta.yaml Show resolved Hide resolved
recipes/libnvjpeg/meta.yaml Outdated Show resolved Hide resolved
recipes/libnvjpeg/meta.yaml Show resolved Hide resolved
recipes/libnvjpeg/meta.yaml Outdated Show resolved Hide resolved
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Recipe looks fine aside from minor suggestions on doc_url. I haven't checked the package contents yet.

@adibbley adibbley marked this pull request as ready for review April 12, 2023 22:16
@jakirkham jakirkham requested a review from bdice April 13, 2023 07:32
recipes/libnvjpeg/meta.yaml Outdated Show resolved Hide resolved
recipes/libnvjpeg/meta.yaml Outdated Show resolved Hide resolved
recipes/libnvjpeg/meta.yaml Outdated Show resolved Hide resolved
adibbley and others added 3 commits April 13, 2023 18:21
Co-authored-by: Vyas Ramasubramani <vyas.ramasubramani@gmail.com>
Copy link
Contributor

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving to unblock things since my requests have been addressed.

recipes/libnvjpeg/meta.yaml Outdated Show resolved Hide resolved
Co-authored-by: Bradley Dice <bdice@bradleydice.com>
@jakirkham jakirkham requested a review from kkraus14 April 15, 2023 00:22
@jakirkham jakirkham merged commit 5a01190 into conda-forge:main Apr 15, 2023
@jakirkham
Copy link
Member

Thanks all! 🙏

Let's follow up on anything else in the feedstock 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

6 participants