Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds jupyter-ai and jupyter-ai-magics YAML files #23959

Merged
merged 15 commits into from
Sep 26, 2023

Conversation

JasonWeill
Copy link
Contributor

@JasonWeill JasonWeill commented Sep 11, 2023

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • N/A If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/jupyter-ai, recipes/jupyter-ai-magics) and found some lint.

Here's what I've got...

For recipes/jupyter-ai:

  • The home item is expected in the about section.

For recipes/jupyter-ai-magics:

  • The home item is expected in the about section.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/jupyter-ai, recipes/jupyter-ai-magics) and found it was in an excellent condition.

@andrii-i
Copy link
Contributor

I agree to be a maintainer

@dlqqq
Copy link
Member

dlqqq commented Sep 13, 2023

I agree to be a maintainer.

1 similar comment
@3coins
Copy link
Contributor

3coins commented Sep 13, 2023

I agree to be a maintainer.

@fcollonval
Copy link
Contributor

Ok looking at the faiss-cpu issue, as the conda package does not install a empty Python package shell as PyPI does. A dirty solution could be to pip install in the test a empty faiss-cpu Python package.

@3coins 3coins force-pushed the jupyter-ai-and-magics branch from 061fda6 to 3f247c5 Compare September 20, 2023 17:12
@3coins
Copy link
Contributor

3coins commented Sep 20, 2023

@fcollonval
Thanks for looking into this. I rebased and added pip install faiss-cpu; monitoring the CI if this works.

@JasonWeill JasonWeill marked this pull request as ready for review September 20, 2023 18:06
@3coins
Copy link
Contributor

3coins commented Sep 20, 2023

@conda-forge-admin, please ping team. PR is ready for review.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-webservice.

I was asked to ping @conda-forge/team. and so here I am doing that.

@JasonWeill
Copy link
Contributor Author

@conda-forge/help-python Ready for review.

- jupyter_server >=1.6,<3
- jupyterlab >=4.0,<5
- pydantic >=1.0,<2.dev0
- openai >=0.26,<1.dev0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there openai and pydantic dev releases on conda-forge?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SylvainCorlay
Thanks for reviewing. I am not sure how to be certain about this, but I could not find any dev releases for both of these with conda search. Given that info, should we update the upper bound for these packages?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Normally, conda-forge should not include pre-releases. (On a separate note, I also think this should not be needed for a PyPI release.)

@3coins
Copy link
Contributor

3coins commented Sep 26, 2023

@SylvainCorlay
Updated the dependencies based on your suggestion.

@SylvainCorlay SylvainCorlay merged commit d378e14 into conda-forge:main Sep 26, 2023
@SylvainCorlay
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

6 participants