-
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding horovod #24472
Adding horovod #24472
Conversation
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/horovod:
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
This comment was marked as resolved.
This comment was marked as resolved.
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/horovod:
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge-admin please restart ci |
@conda-forge/help-python-c ready for review. The package is built against both tensorflow and pytorch, but one is free to install only one of them. |
- flatbuffers | ||
- tensorflow | ||
- pytorch | ||
missing_dso_whitelist: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a comment here why they are listed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added. Thanks for the review.
Co-authored-by: Uwe L. Korn <xhochy@users.noreply.github.com>
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/horovod:
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Recently I contributed Horovod to conda-forge at conda-forge/staged-recipes#24472. I have tested it with DeePMD-kit. Now the Conda-forge channel has all the features in our deepmodeling channel and even more available platforms. I wonder if we should recommend Conda-forge in favor of our DeepModeling channel and use it for the offline installer. In 2019, Conda-forge lacked support for TensorFlow, so we hosted and built our own channel against the Anaconda channel. But now Conda-forge has become a mature channel and has better support for TensorFlow than the Anaconda channel. Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Resolves #6228.
Checklist
url
) rather than a repo (e.g.git_url
) is used in your recipe (see here for more details).