Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding horovod #24472

Merged
merged 25 commits into from
Nov 19, 2023
Merged

Adding horovod #24472

merged 25 commits into from
Nov 19, 2023

Conversation

njzjz
Copy link
Member

@njzjz njzjz commented Nov 10, 2023

Resolves #6228.

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/horovod) and found some lint.

Here's what I've got...

For recipes/horovod:

  • Failed to even lint the recipe, probably because of a conda-smithy bug 😢. This likely indicates a problem in your meta.yaml, though. To get a traceback to help figure out what's going on, install conda-smithy and run conda smithy recipe-lint . from the recipe directory.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/horovod) and found it was in an excellent condition.

@njzjz

This comment was marked as resolved.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/horovod) and found some lint.

Here's what I've got...

For recipes/horovod:

  • The requirements section contained an unexpected subsection name. ignore_run_exports_from is not a valid subsection name.
  • The requirements section contained an unexpected subsection name. missing_dso_whitelist is not a valid subsection name.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/horovod) and found it was in an excellent condition.

@njzjz
Copy link
Member Author

njzjz commented Nov 12, 2023

@conda-forge-admin please restart ci

@njzjz njzjz marked this pull request as ready for review November 12, 2023 08:36
@njzjz
Copy link
Member Author

njzjz commented Nov 12, 2023

@conda-forge/help-python-c ready for review.

The package is built against both tensorflow and pytorch, but one is free to install only one of them.

- flatbuffers
- tensorflow
- pytorch
missing_dso_whitelist:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a comment here why they are listed.

Copy link
Member Author

@njzjz njzjz Nov 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added. Thanks for the review.

recipes/horovod/meta.yaml Outdated Show resolved Hide resolved
Co-authored-by: Uwe L. Korn <xhochy@users.noreply.github.com>
@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/horovod) and found some lint.

Here's what I've got...

For recipes/horovod:

  • Failed to even lint the recipe, probably because of a conda-smithy bug 😢. This likely indicates a problem in your meta.yaml, though. To get a traceback to help figure out what's going on, install conda-smithy and run conda smithy recipe-lint . from the recipe directory.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/horovod) and found it was in an excellent condition.

@xhochy xhochy merged commit 454e293 into conda-forge:main Nov 19, 2023
5 checks passed
wanghan-iapcm pushed a commit to deepmodeling/deepmd-kit that referenced this pull request Nov 21, 2023
Recently I contributed Horovod to conda-forge at
conda-forge/staged-recipes#24472. I have tested
it with DeePMD-kit. Now the Conda-forge channel has all the features in
our deepmodeling channel and even more available platforms.

I wonder if we should recommend Conda-forge in favor of our DeepModeling
channel and use it for the offline installer. In 2019, Conda-forge
lacked support for TensorFlow, so we hosted and built our own channel
against the Anaconda channel. But now Conda-forge has become a mature
channel and has better support for TensorFlow than the Anaconda channel.

Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Package horovod
2 participants