Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add pyQParamWidget package #25891

Merged
merged 13 commits into from
Apr 2, 2024
Merged

Conversation

prjemian
Copy link
Contributor

@prjemian prjemian commented Mar 28, 2024

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@prjemian
Copy link
Contributor Author

I am willing to be a maintainer of this recipe.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/pyQParamWidget) and found some lint.

Here's what I've got...

For recipes/pyQParamWidget:

  • The home item is expected in the about section.

For recipes/pyQParamWidget:

  • License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

Documentation on acceptable licenses can be found here.

@prjemian
Copy link
Contributor Author

meta.yaml was built with grayskull

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/pyQParamWidget) and found it was in an excellent condition.

@prjemian
Copy link
Contributor Author

Not understanding why this happened here:

2024-03-28T22:11:59.4240137Z     from PyQt5 import QtWidgets
2024-03-28T22:11:59.4240433Z ImportError: libGL.so.1: cannot open shared object file: No such file or directory

Amongst the package installs:

2024-03-28T22:11:34.1121858Z     libglib:                   2.80.0-hf2295e7_1         conda-forge

Was the package installed into the wrong place or what other problem? Looks like an upstream problem.

@prjemian
Copy link
Contributor Author

Could it be a line-length problem here? Looks truncated:

2024-03-28T22:11:58.9590294Z export PREFIX=/home/conda/staged-recipes/build_artifacts/pyqparamwidget_1711663791066/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_p

@prjemian
Copy link
Contributor Author

Or add libgl1-mesa-glx to recipe:requirements:run

@prjemian
Copy link
Contributor Author

Ok, comment out the import test worked. But, kosher? Restore and add requirement next.

@prjemian
Copy link
Contributor Author

Failed result:

Encountered problems while solving:
  - nothing provides requested libgl1-mesa-glx

@prjemian
Copy link
Contributor Author

Did not work. Import failed as first reported. Investigate the instructions to resolve with libgl1-mesa-glx.

@prjemian
Copy link
Contributor Author

Compare with feedstock of another PyQt5 project: PyDM

@prjemian
Copy link
Contributor Author

@conda-forge-admin please rerender

@prjemian
Copy link
Contributor Author

PyDM recipe was contributed in 2019. New recipe structure has changed.

@prjemian
Copy link
Contributor Author

Tried to rerender locally, but FileNotFoundError. First updated local conda-smithy package

  conda-smithy                          3.30.4-pyhd8ed1ab_0 --> 3.34.0-pyhd8ed1ab_0 

then

(smithy) prjemian@arf:~/.../conda-forge/staged-recipes$ conda-smithy rerender                                                      
INFO:conda_smithy.configure_feedstock:Downloading conda-forge-pinning-2024.03.29.12.36.21                                                             
INFO:conda_smithy.configure_feedstock:Extracting conda-forge-pinning to /home/prjemian/.cache/conda-smithy                                            
INFO:conda_smithy.configure_feedstock:__pycache__ rendering is skipped
INFO:conda_smithy.configure_feedstock:README rendering is skipped
Traceback (most recent call last):
  File "/home/prjemian/.conda/envs/smithy/bin/conda-smithy", line 10, in <module>
    sys.exit(main())
             ^^^^^^
  File "/home/prjemian/.conda/envs/smithy/lib/python3.11/site-packages/conda_smithy/cli.py", line 737, in main
    args.subcommand_func(args)
  File "/home/prjemian/.conda/envs/smithy/lib/python3.11/site-packages/conda_smithy/cli.py", line 584, in __call__
    self._call(args, tmpdir)
  File "/home/prjemian/.conda/envs/smithy/lib/python3.11/site-packages/conda_smithy/cli.py", line 589, in _call
    configure_feedstock.main(
  File "/home/prjemian/.conda/envs/smithy/lib/python3.11/site-packages/conda_smithy/configure_feedstock.py", line 2655, in main
    render_azure(env, config, forge_dir, return_metadata=True)
  File "/home/prjemian/.conda/envs/smithy/lib/python3.11/site-packages/conda_smithy/configure_feedstock.py", line 1764, in render_azure
    return _render_ci_provider(
           ^^^^^^^^^^^^^^^^^^^^
  File "/home/prjemian/.conda/envs/smithy/lib/python3.11/site-packages/conda_smithy/configure_feedstock.py", line 900, in _render_ci_provider
    with open(
         ^^^^^
FileNotFoundError: [Errno 2] No such file or directory: '/home/prjemian/Documents/projects/conda-forge/staged-recipes/recipe/meta.yaml'

@prjemian
Copy link
Contributor Author

rerender does not work in this case. At this stage, the recipe is not in a "feedstock". Dig deeper into the knowledge base for more guidance.

@prjemian
Copy link
Contributor Author

Hey! That worked!

@prjemian
Copy link
Contributor Author

Ready for review now.

@prjemian
Copy link
Contributor Author

@conda-forge/help-python all test pass. This PR is ready for review.

Co-authored-by: Filipe <ocefpaf@gmail.com>
@prjemian
Copy link
Contributor Author

prjemian commented Apr 1, 2024

@ocefpaf - Your changes have been accepted. Thanks for the feedback. Ready for review.

@ocefpaf ocefpaf merged commit 03e781d into conda-forge:main Apr 2, 2024
5 checks passed
@prjemian
Copy link
Contributor Author

prjemian commented Apr 2, 2024

@ocefpaf, Thanks!

@prjemian prjemian deleted the pyQParamWidget-package branch April 2, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants