Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deptry #26614

Merged
merged 15 commits into from
Jun 13, 2024
Merged

Add deptry #26614

merged 15 commits into from
Jun 13, 2024

Conversation

maresb
Copy link
Contributor

@maresb maresb commented Jun 9, 2024

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/deptry) and found some lint.

Here's what I've got...

For recipes/deptry:

  • The home item is expected in the about section.
  • Non noarch packages should have python requirement without any version constraints.
  • Non noarch packages should have python requirement without any version constraints.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/deptry) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipes/deptry:

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/deptry) and found it was in an excellent condition.

@maresb
Copy link
Contributor Author

maresb commented Jun 9, 2024

@conda-forge/help-python-c, ready for review of this Rust/Maturin recipe. (I hope this is the right team; it seemed the closest to Python/Rust.)

I seem to be hitting conda/conda-build#5122 when building on Windows, and it doesn't seem to me like there are currently any viable workarounds. Should I just disable Windows for now?

To be specific, during the build process this package depends on the ruff repository, and there are some huge filenames in there that Windows simply chokes on.

Caused by:
  failed to load source for dependency `ruff_python_ast`

Caused by:
  Unable to update https://github.com/astral-sh/ruff?tag=v0.3.4#5062572a

Caused by:
  path too long: 'C:/bld/deptry_1717936673004/_build_env/.cargo/git/checkouts/ruff-194cdb01f61cb8d9/5062572/crates/ruff_linter/src/rules/flake8_quotes/snapshots/ruff_linter__rules__flake8_quotes__tests__require_docstring_doubles_over_docstring_singles_mixed_quotes_class_var_1.py.snap'; class=Filesystem (30)

@fpgmaas
Copy link

fpgmaas commented Jun 10, 2024

GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.

I'm ok with this

@xhochy xhochy merged commit 6549ba5 into conda-forge:main Jun 13, 2024
5 checks passed
@maresb maresb deleted the deptry branch June 13, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants