Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sam-2 #27288

Merged
merged 22 commits into from
Nov 4, 2024
Merged

Add sam-2 #27288

merged 22 commits into from
Nov 4, 2024

Conversation

hmaarrfk
Copy link
Contributor

@hmaarrfk hmaarrfk commented Aug 16, 2024

Packages https://github.com/facebookresearch/segment-anything-2

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/sam2/meta.yaml) and found it was in an excellent condition.

@hmaarrfk hmaarrfk closed this Aug 16, 2024
@hmaarrfk hmaarrfk reopened this Aug 16, 2024
@hmaarrfk hmaarrfk marked this pull request as ready for review August 16, 2024 18:42
@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/sam2/meta.yaml) and found some lint.

Here's what I've got...

For recipes/sam2/meta.yaml:

  • noarch packages can't have skips with selectors. If the selectors are necessary, please remove noarch: python.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/sam2/meta.yaml) and found it was in an excellent condition.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/sam-2/meta.yaml) and found it was in an excellent condition.

@hmaarrfk hmaarrfk changed the title Add sam2 Add sam-2 Aug 17, 2024
@hmaarrfk hmaarrfk marked this pull request as draft August 20, 2024 18:34
@hmaarrfk
Copy link
Contributor Author

I'm marking this as draft since this package is good enough for my own usecases.

If somebody else wants this package, please ping here and I'm happy to discuss how we can get unversionned software to be uploaded here.

Its not my favorite thing to do.

Ultimately, if META puts it on PyPI then i would merge much faster

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/sam-2/meta.yaml) and found some lint.

Here's what I've got...

For recipes/sam-2/meta.yaml:

  • noarch packages can't have skips with selectors. If the selectors are necessary, please remove noarch: python.
  • noarch: python recipes are required to have a lower bound on the python version. Typically this means putting python >=3.6 in both host and run but you should check upstream for the package's Python compatibility.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/sam-2/meta.yaml) and found some lint.

Here's what I've got...

For recipes/sam-2/meta.yaml:

  • noarch packages can't have skips with selectors. If the selectors are necessary, please remove noarch: python.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/sam-2/meta.yaml) and found some lint.

Here's what I've got...

For recipes/sam-2/meta.yaml:

  • Failed to even lint the recipe, probably because of a conda-smithy bug 😢. This likely indicates a problem in your meta.yaml, though. To get a traceback to help figure out what's going on, install conda-smithy and run conda smithy recipe-lint . from the recipe directory.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/sam-2/meta.yaml) and found it was in an excellent condition.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/sam-2/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipes/sam-2/meta.yaml:

  • No valid build backend found for Python recipe for package sam-2 using pip. Python recipes using pip need to explicitly specify a build backend in the host section. If your recipe has built with only pip in the host section in the past, you likely should add setuptools to the host section of your recipe.

@hmaarrfk hmaarrfk marked this pull request as ready for review November 4, 2024 02:54
Copy link
Contributor

github-actions bot commented Nov 4, 2024

Hi! This is the staged-recipes linter and your PR looks excellent! 🚀

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/sam-2/meta.yaml) and found it was in an excellent condition.

@hmaarrfk hmaarrfk merged commit a5b7280 into conda-forge:main Nov 4, 2024
7 of 9 checks passed
@hadim
Copy link
Member

hadim commented Nov 4, 2024

It seems like the bot is failing creating this feedstock:

Repository created, please edit recipe/conda_build_config.yaml to configure the upload channels
and afterwards call 'conda smithy register-github'
WARNING: No numpy version specified in conda_build_config.yaml.  Falling back to default numpy value of 1.26
Adding in variants from internal_defaults
Adding in variants from /tmp/tmplw8obrbm__feedstocks/sam-2-feedstock/recipe/conda_build_config.yaml
Traceback (most recent call last):
  File "/home/runner/Miniforge3/lib/python3.12/site-packages/conda_build/metadata.py", line 2003, in _get_contents
    rendered = template.render(environment=env)
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/runner/Miniforge3/lib/python3.12/site-packages/jinja2/environment.py", line 1304, in render
    self.environment.handle_exception()
  File "/home/runner/Miniforge3/lib/python3.12/site-packages/jinja2/environment.py", line 939, in handle_exception
    raise rewrite_traceback_stack(source=source)
  File "/tmp/tmplw8obrbm__feedstocks/sam-2-feedstock/recipe/meta.yaml", line 6, in top-level template code
    {% if cuda_compiler_version in (None, "None", True, False) %}
    ^^^^^^^^^^^^^^^^^^^^^^^^^
jinja2.exceptions.UndefinedError: 'cuda_compiler_version' is undefined

During handling of the above exception, another exception occurred:

At https://github.com/conda-forge/admin-requests/actions/runs/11669947190/job/32493080473

It also prevents the creation of the other feedstocks in staged-recipes.

@hmaarrfk
Copy link
Contributor Author

hmaarrfk commented Nov 4, 2024

Thanks lets see if #28100 fixes it

@hmaarrfk hmaarrfk mentioned this pull request Nov 4, 2024
10 tasks
@hmaarrfk
Copy link
Contributor Author

hmaarrfk commented Nov 4, 2024

well sorry about that, packages getting built up again.

@hadim
Copy link
Member

hadim commented Nov 4, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants