Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dydx_v4_client_lib - WIP: Awaiting dydx-v4-proto-cpp #27393

Open
wants to merge 49 commits into
base: main
Choose a base branch
from

Conversation

MementoRC
Copy link
Contributor

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/dydx-v4-client-cpp/meta.yaml) and found it was in an excellent condition.

@MementoRC MementoRC changed the title Add dydx_v4_client_lib Add dydx_v4_client_lib - WIP: Awaiting dydx-v4-proto-cpp Aug 25, 2024
@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/dydx-v4-client-cpp/meta.yaml, recipes/dydxprotocol-v4-proto-cpp/meta.yaml) and found it was in an excellent condition.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/dydx-v4-client-cpp/meta.yaml, recipes/libdydx_v4_proto/meta.yaml) and found it was in an excellent condition.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/_libdydx_v4_proto/meta.yaml, recipes/dydx-v4-client-cpp/meta.yaml) and found it was in an excellent condition.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/dydx-v4-client-cpp/meta.yaml, recipes/libdydx_v4_proto-0/meta.yaml, recipes/libdydx_v4_proto-devel/meta.yaml, recipes/libdydx_v4_proto-headers-0/meta.yaml) and found some lint.

Here's what I've got...

For recipes/libdydx_v4_proto-devel/meta.yaml:

  • The recipe must have some tests.
  • The requirements section contained an unexpected subsection name. test is not a valid subsection name.
  • pin_compatible should be used instead of pin_subpackage for libdydx_v4_proto-0 because it is not a known output of this recipe: ['libdydx_v4_proto-devel'].
  • pin_compatible should be used instead of pin_subpackage for libdydx_v4_proto-0 because it is not a known output of this recipe: ['libdydx_v4_proto-devel'].
  • pin_compatible should be used instead of pin_subpackage for libdydx_v4_proto-headers-0 because it is not a known output of this recipe: ['libdydx_v4_proto-devel'].
  • pin_compatible should be used instead of pin_subpackage for libdydx_v4_proto-0 because it is not a known output of this recipe: ['libdydx_v4_proto-devel'].
  • pin_compatible should be used instead of pin_subpackage for libdydx_v4_proto-headers-0 because it is not a known output of this recipe: ['libdydx_v4_proto-devel'].

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/dydx-v4-client-cpp/meta.yaml, recipes/libdydx_v4_proto-0/meta.yaml, recipes/libdydx_v4_proto-devel/meta.yaml, recipes/libdydx_v4_proto-headers-0/meta.yaml) and found some lint.

Here's what I've got...

For recipes/libdydx_v4_proto-0/meta.yaml:

  • pin_subpackage should be used instead of pin_compatible for libdydx_v4_proto-0 because it is one of the known outputs of this recipe: ['libdydx_v4_proto-0'].

For recipes/libdydx_v4_proto-devel/meta.yaml:

  • The recipe must have some tests.
  • The requirements section contained an unexpected subsection name. test is not a valid subsection name.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/dydx-v4-client-cpp/meta.yaml, recipes/libdydx_v4_proto-devel/meta.yaml) and found some lint.

Here's what I've got...

For recipes/libdydx_v4_proto-devel/meta.yaml:

  • The recipe must have some tests.
  • The requirements section contained an unexpected subsection name. test is not a valid subsection name.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/dydx-v4-client-cpp/meta.yaml, recipes/libdydx_v4_proto-devel/meta.yaml) and found it was in an excellent condition.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/dydx-v4-client-cpp/meta.yaml, recipes/libdydx_v4_proto-devel/meta.yaml) and found it was in an excellent condition.

Copy link

Hi! This is the staged-recipes linter and your PR looks excellent! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant