Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added nanocube as a package #28011

Merged
merged 10 commits into from
Nov 18, 2024
Merged

Added nanocube as a package #28011

merged 10 commits into from
Nov 18, 2024

Conversation

thewchan
Copy link
Contributor

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

Copy link
Contributor

Hi! This is the staged-recipes linter and I found some lint.

File-specific lints and/or hints:

  • recipes/nanocube/meta.yaml:
    • lints:
      • The following maintainers have not yet confirmed that they are willing to be listed here: changminkim-329. Please ask them to comment on this PR if they are.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/nanocube/meta.yaml) and found it was in an excellent condition.

Copy link
Contributor

Hi! This is the staged-recipes linter and your PR looks excellent! 🚀

@thewchan
Copy link
Contributor Author

@conda-forge/help-python @conda-forge/staged-recipes Ready for review!

Copy link
Contributor

To help direct your pull request to the best reviewers, please mention a topic-specifc team if your recipe matches any of the following: conda-forge/help-c-cpp, conda-forge/help-cdts, conda-forge/help-go, conda-forge/help-java, conda-forge/help-julia, conda-forge/help-nodejs, conda-forge/help-perl, conda-forge/help-python, conda-forge/help-python-c, conda-forge/help-r, conda-forge/help-ruby,or conda-forge/help-rust. Thanks!

@thewchan thewchan closed this Oct 31, 2024
@thewchan thewchan reopened this Oct 31, 2024
@ocefpaf
Copy link
Member

ocefpaf commented Nov 1, 2024

Seems like it is not picking up the updated one and I'm not in the mood to send a repodata patch for the old builds... I do that when the ☕ kicks in.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/nanocube/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipes/nanocube/meta.yaml:

  • ℹ️ noarch: python recipes should usually follow the syntax in our documentation for specifying the Python version.
    • For the host section of the recipe, you should usually use python {{ python_min }} for the python entry.
    • For the run section of the recipe, you should usually use python >={{ python_min }} for the python entry.
    • For the test.requires section of the recipe, you should usually use python {{ python_min }} for the python entry.
    • If the package requires a newer Python version than the currently supported minimum version on conda-forge, you can override the python_min variable by adding a Jinja2 set statement at the top of your recipe (or using an equivalent context variable for v1 recipes).

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I failed to even lint the recipe, probably because of a conda-smithy bug 😢. This likely indicates a problem in your meta.yaml, though. To get a traceback to help figure out what's going on, install conda-smithy and run conda smithy recipe-lint --conda-forge . from the recipe directory.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/11871763949.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/nanocube/meta.yaml) and found it was in an excellent condition.

run:
- python >={{ python_min }}
# Pip check complains about numpy version
# - numpy <2,>=1.17.3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# - numpy <2,>=1.17.3

@ocefpaf ocefpaf merged commit 2eae1f3 into conda-forge:main Nov 18, 2024
5 of 7 checks passed
@thewchan
Copy link
Contributor Author

@ocefpaf do you know what's going on with the OSX build? (thanks for the merge btw)

@ocefpaf
Copy link
Member

ocefpaf commented Nov 18, 2024

@ocefpaf do you know what's going on with the OSX build? (thanks for the merge btw)

Is was fixed. See #28242 for more info,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants