-
-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add recipe for basedpyright #28367
add recipe for basedpyright #28367
Conversation
Hi! This is the staged-recipes linter and I found some lint. File-specific lints and/or hints:
|
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/basedpyright/meta.yaml:
For recipes/basedpyright/meta.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12033797896. Examine the logs at this URL for more detail. |
b5cce71
to
f50f0ea
Compare
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge/help-nodejs grayskull generated a recipe with |
I made a comment in the linked issue here: DetachHead/basedpyright#410 (comment). I'm hoping the upstream developer is open to providing an option for users to just an existing NodeJS installation instead of vendoring it with |
For starters, you could patch out the dependency from |
8697399
to
b70810a
Compare
|
eb0c8b3
to
1bcba79
Compare
thanks @xhochy, looks like that worked! @DetachHead would you like to be added as a maintainer here? |
sure, though i wont be much help since i don't use conda |
1bcba79
to
da1f276
Compare
Hi! This is the staged-recipes linter and your PR looks excellent! 🚀 |
@conda-forge/help-nodejs @conda-forge/help-python ready for review, thanks! :) |
Hmm, I'm sure the patch succeeded in CI once, but is now failing to be applied. |
@xhochy nodejs_wheel doesn't seem to be a wheel for nodejs but rather a pure python wrapper to call an installed node binary. @lucascolley I guess you'll have to Edit: I can't make heads or tails from the package upstream. There is a pure python wrapper but the source on PyPI is not it and the sdist on GH has a completely different pyproject.toml. |
Hi this is the author of
The wheel part and the python wrapper ( |
sounds like that would be useful, thanks! |
#28400 is ready for review. |
Co-authored-by: Filipe <ocefpaf@gmail.com>
@njzjz would you be able to contribute a package for |
Please use |
@conda-forge/help-nodejs, @conda-forge/help-python, CI passing, ready for review, thanks!! |
thank you all!! |
DetachHead/basedpyright#410
Checklist
url
) rather than a repo (e.g.git_url
) is used in your recipe (see here for more details).