Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add recipe for basedpyright #28367

Merged
merged 11 commits into from
Nov 29, 2024
Merged

add recipe for basedpyright #28367

merged 11 commits into from
Nov 29, 2024

Conversation

lucascolley
Copy link
Member

@lucascolley lucascolley commented Nov 26, 2024

DetachHead/basedpyright#410

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

Copy link
Contributor

Hi! This is the staged-recipes linter and I found some lint.

File-specific lints and/or hints:

  • recipes/basedpyright/meta.yaml:
    • lints:
      • The following maintainers have not yet confirmed that they are willing to be listed here: DetachHead. Please ask them to comment on this PR if they are.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/basedpyright/meta.yaml) and found some lint.

Here's what I've got...

For recipes/basedpyright/meta.yaml:

  • ❌ The home item is expected in the about section.

For recipes/basedpyright/meta.yaml:

  • ℹ️ noarch: python recipes should usually follow the syntax in our documentation for specifying the Python version.
    • For the host section of the recipe, you should usually use python {{ python_min }} for the python entry.
    • For the run section of the recipe, you should usually use python >={{ python_min }} for the python entry.
    • For the test.requires section of the recipe, you should usually use python {{ python_min }} for the python entry.
    • If the package requires a newer Python version than the currently supported minimum version on conda-forge, you can override the python_min variable by adding a Jinja2 set statement at the top of your recipe (or using an equivalent context variable for v1 recipes).
  • ℹ️ PyPI default URL is now pypi.org, and not pypi.io. You may want to update the default source url.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12033797896. Examine the logs at this URL for more detail.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/basedpyright/meta.yaml) and found it was in an excellent condition.

@lucascolley
Copy link
Member Author

@conda-forge/help-nodejs grayskull generated a recipe with nodejs-wheel - what do we need to do to get that working?

@danielnachun
Copy link
Contributor

I made a comment in the linked issue here: DetachHead/basedpyright#410 (comment). I'm hoping the upstream developer is open to providing an option for users to just an existing NodeJS installation instead of vendoring it with nodejs-wheel.

@xhochy
Copy link
Member

xhochy commented Nov 27, 2024

For starters, you could patch out the dependency from pyproject.toml and add a run dependency on nodejs >=20. That would be OK to get it working.

@lucascolley
Copy link
Member Author

lucascolley commented Nov 27, 2024

docify >=1.0.0 does not exist (gh-28383)

@lucascolley lucascolley mentioned this pull request Nov 27, 2024
10 tasks
@lucascolley lucascolley force-pushed the basedpyright branch 2 times, most recently from eb0c8b3 to 1bcba79 Compare November 27, 2024 15:18
@lucascolley
Copy link
Member Author

thanks @xhochy, looks like that worked!

@DetachHead would you like to be added as a maintainer here?

@DetachHead
Copy link

sure, though i wont be much help since i don't use conda

@lucascolley lucascolley marked this pull request as ready for review November 27, 2024 21:13
Copy link
Contributor

Hi! This is the staged-recipes linter and your PR looks excellent! 🚀

@lucascolley
Copy link
Member Author

@conda-forge/help-nodejs @conda-forge/help-python ready for review, thanks! :)

@lucascolley
Copy link
Member Author

Hmm, I'm sure the patch succeeded in CI once, but is now failing to be applied.

@ocefpaf
Copy link
Member

ocefpaf commented Nov 28, 2024

For starters, you could patch out the dependency from pyproject.toml and add a run dependency on nodejs >=20. That would be OK to get it working.

@xhochy nodejs_wheel doesn't seem to be a wheel for nodejs but rather a pure python wrapper to call an installed node binary.

@lucascolley I guess you'll have to nodejs_wheel as a package and drop the patch.


Edit: I can't make heads or tails from the package upstream. There is a pure python wrapper but the source on PyPI is not it and the sdist on GH has a completely different pyproject.toml.

@njzjz
Copy link
Member

njzjz commented Nov 28, 2024

Hi this is the author of nodejs-wheel. I could contribute a recipe to conda-forge if it is needed by basedpyright.

nodejs_wheel doesn't seem to be a wheel for nodejs but rather a pure python wrapper to call an installed node binary.

The wheel part and the python wrapper (nodejs_wheel module) are both in the nodejs-wheel-binaries package. nodejs-wheel is an empty package which depends on nodejs-wheel-binaries but adds entry points (node, npm, npx) which might be conflict with system's already installed nodejs. The GH repo contains pyproject.toml for both packages (one in the root directory and the other in the cmd directory).

@lucascolley
Copy link
Member Author

I could contribute a recipe to conda-forge if it is needed by basedpyright

sounds like that would be useful, thanks!

@njzjz njzjz mentioned this pull request Nov 28, 2024
10 tasks
@njzjz
Copy link
Member

njzjz commented Nov 29, 2024

I could contribute a recipe to conda-forge if it is needed by basedpyright.

#28400 is ready for review.

lucascolley and others added 2 commits November 29, 2024 14:30
Co-authored-by: Filipe <ocefpaf@gmail.com>
@lucascolley
Copy link
Member Author

@njzjz would you be able to contribute a package for nodejs-wheel-binaries as well? It seems like that is a runtime dependency here

@njzjz
Copy link
Member

njzjz commented Nov 29, 2024

@njzjz would you be able to contribute a package for nodejs-wheel-binaries as well? It seems like that is a runtime dependency here

Please use nodejs-wheel directly

@lucascolley
Copy link
Member Author

lucascolley commented Nov 29, 2024

@conda-forge/help-nodejs, @conda-forge/help-python, CI passing, ready for review, thanks!!

@xhochy xhochy merged commit 444a5dc into conda-forge:main Nov 29, 2024
7 checks passed
@lucascolley
Copy link
Member Author

thank you all!!

@lucascolley lucascolley deleted the basedpyright branch November 29, 2024 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

7 participants