Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MPFUN90 #28415

Merged
merged 1 commit into from
Dec 5, 2024
Merged

Add MPFUN90 #28415

merged 1 commit into from
Dec 5, 2024

Conversation

matthewfeickert
Copy link
Member

@matthewfeickert matthewfeickert commented Nov 30, 2024

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

Copy link
Contributor

Hi! This is the staged-recipes linter and your PR looks excellent! 🚀

@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Nov 30, 2024

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/mpfun90/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipes/mpfun90/meta.yaml:

  • ℹ️ License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

Documentation on acceptable licenses can be found here.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12176686128. Examine the logs at this URL for more detail.

@matthewfeickert
Copy link
Member Author

@APN-Pucky once we get the license issues resolved with David let's upstream the correct license to https://github.com/APN-Pucky/mpfun90 and then I'll update things here.

@matthewfeickert matthewfeickert marked this pull request as ready for review December 5, 2024 09:23
@matthewfeickert
Copy link
Member Author

@conda-forge/staged-recipes, ready for review! This is a fortran recipe.

Copy link
Contributor

github-actions bot commented Dec 5, 2024

To help direct your pull request to the best reviewers, please mention a topic-specifc team if your recipe matches any of the following: conda-forge/help-c-cpp, conda-forge/help-cdts, conda-forge/help-go, conda-forge/help-java, conda-forge/help-julia, conda-forge/help-nodejs, conda-forge/help-perl, conda-forge/help-python, conda-forge/help-python-c, conda-forge/help-r, conda-forge/help-ruby,or conda-forge/help-rust. Thanks!

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/mpfun90/meta.yaml) and found it was in an excellent condition.

@xhochy xhochy closed this Dec 5, 2024
@xhochy xhochy reopened this Dec 5, 2024
@xhochy
Copy link
Member

xhochy commented Dec 5, 2024

🤔 Azure Pipelines did not trigger here.

@matthewfeickert
Copy link
Member Author

🤔 Azure Pipelines did not trigger here.

I think for similar reasons as conda-forge/conda-forge-webservices#773. I'll just rebase this locally and do a --force-with-lease push.

* Add MPFUN90 from 2010-08-25.
   - c.f. https://github.com/APN-Pucky/mpfun90
* MPFUN90 is now archival software but is still required in areas of particle physics.
@xhochy xhochy merged commit 450cc38 into conda-forge:main Dec 5, 2024
7 checks passed
@matthewfeickert matthewfeickert deleted the feat/add-mpfun90 branch December 5, 2024 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants