Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add recipe for rte-rrtmgp #28640

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

makepath-alex
Copy link

@makepath-alex makepath-alex commented Dec 18, 2024

Summary
This PR adds a new recipe for the package rte-rrtmgp, which is a Fortran library for computing radiative fluxes in planetary atmospheres. It builds successfully on Windows, Linux, and macOS.

Checklist

  • Recipe follows conda-forge guidelines
  • Package builds on Linux, Windows, and macOS
  • I am listed as a maintainer of the package

Maintainers

Copy link
Contributor

Hi! This is the staged-recipes linter and I found some lint.

File-specific lints and/or hints:

  • recipes/rte-rrtmgp/meta.yaml:
    • lints:
      • The following maintainers have not yet confirmed that they are willing to be listed here: RobertPincus. Please ask them to comment on this PR if they are.

@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Dec 18, 2024

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/rte-rrtmgp/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipes/rte-rrtmgp/meta.yaml:

  • ℹ️ Recipes should usually depend on matplotlib-base as opposed to matplotlib so that runtime environments do not require large packages like qt.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12397152661. Examine the logs at this URL for more detail.

@RobertPincus
Copy link

I agree to act as a maintainer of this recipe.

Copy link
Contributor

Hi! This is the staged-recipes linter and your PR looks excellent! 🚀

@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Dec 18, 2024

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/rte-rrtmgp/meta.yaml) and found some lint.

Here's what I've got...

For recipes/rte-rrtmgp/meta.yaml:

  • ❌ The top level meta keys are in an unexpected order. Expecting ['package', 'source', 'build', 'requirements', 'test', 'outputs', 'about', 'extra'].
  • ❌ Selectors are suggested to take a <two spaces>#<one space>[<expression>] form. See lines [17, 54, 81]
  • ❌ There are too few lines. There should be one empty line at the end of the file.

For recipes/rte-rrtmgp/meta.yaml:

  • ℹ️ Recipes should usually depend on matplotlib-base as opposed to matplotlib so that runtime environments do not require large packages like qt.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12412600279. Examine the logs at this URL for more detail.

Copy link
Contributor

Hi! This is the staged-recipes linter and your PR looks excellent but I have some suggestions.

File-specific lints and/or hints:

  • recipes/rte-rrtmgp/meta.yaml:
    • hints:
      • It looks like you are submitting a multi-output recipe. In these cases, the correct name for the feedstock is ambiguous, and our infrastructure defaults to the top-level package.name field. Please add a feedstock-name entry in the extra section.

@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Dec 19, 2024

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/rte-rrtmgp/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipes/rte-rrtmgp/meta.yaml:

  • ℹ️ Recipes should usually depend on matplotlib-base as opposed to matplotlib so that runtime environments do not require large packages like qt.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12435270709. Examine the logs at this URL for more detail.

@makepath-alex makepath-alex force-pushed the add-rte-rrtmgp branch 2 times, most recently from ac1c515 to 78252f0 Compare December 19, 2024 17:39
@makepath-alex makepath-alex force-pushed the add-rte-rrtmgp branch 3 times, most recently from e75a8ee to cbbdbe1 Compare December 19, 2024 18:58
@makepath-alex makepath-alex force-pushed the add-rte-rrtmgp branch 5 times, most recently from 33dfc40 to 797d750 Compare December 19, 2024 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants