-
-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add torchserve #28650
base: main
Are you sure you want to change the base?
Add torchserve #28650
Conversation
Hi! This is the staged-recipes linter and your PR looks excellent! 🚀 |
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/torchserve/meta.yaml:
For recipes/torchserve/meta.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12419085590. Examine the logs at this URL for more detail. |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Current failure seems to be this message from gradle:
gradle 7.6 is being selected by https://github.com/pytorch/serve/blob/0985386d5a9bc9dd4fe0feaa7af186e2e5b3a84b/frontend/gradle/wrapper/gradle-wrapper.properties#L3, which I think requires openjdk of at most 19 according to https://docs.gradle.org/current/userguide/compatibility.html |
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/torch-model-archiver/meta.yaml:
For recipes/torch-model-archiver/meta.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12422357757. Examine the logs at this URL for more detail. |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge/help-python, ready for review! I think the macOS failure is irrelevant. |
This is part of the pytorch ecosystem that will be useful to package in light of the deprecation of the pytorch channel.
Torchserve has a Java component and a Python component that are shipped in a single wheel by upstream. The upstream build process builds a jar and rolls it into a wheel; the pytorch channel package build just unpacks and repackages the wheel: https://github.com/pytorch/serve/tree/0985386d5a9bc9dd4fe0feaa7af186e2e5b3a84b/binaries
The upstream wheel is a universal wheel: https://pypi.org/project/torchserve/#files
I think the dependencies rolled into the jar are described in https://github.com/pytorch/serve/blob/master/frontend/server/build.gradle.
I'm not sure whether it's appropriate to add run-constraints or dependencies on pytorch. There are platform support matrices on the Releases page, though torchserve versions are paired with different versions of pytorch in each table: https://github.com/pytorch/serve/releases
Upstream's package did not have any dependencies on pytorch: https://github.com/pytorch/serve/blob/master/binaries/conda/torchserve/meta.yaml
Checklist
url
) rather than a repo (e.g.git_url
) is used in your recipe (see here for more details).