Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add aerc package #28666

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Add aerc package #28666

wants to merge 10 commits into from

Conversation

blmaier
Copy link
Contributor

@blmaier blmaier commented Dec 20, 2024

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

Copy link
Contributor

Hi! This is the staged-recipes linter and your PR looks excellent! 🚀

@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Dec 20, 2024

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/aerc/recipe.yaml) and found some lint.

Here's what I've got...

For recipes/aerc/recipe.yaml:

  • ❌ The top level meta key schema_version is unexpected

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12432909495. Examine the logs at this URL for more detail.

Launching full aerc requires a /dev/tty which is not present on the
Conda builders.
@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/aerc/recipe.yaml) and found it was in an excellent condition.

Fix for following error

  Undefined symbols for architecture x86_64:
    "_SecTrustEvaluateWithError", referenced from:
        _crypto/x509/internal/macos.x509_SecTrustEvaluateWithError_trampoline.abi0 in go.o
@blmaier blmaier closed this Dec 20, 2024
@blmaier blmaier reopened this Dec 20, 2024
@blmaier blmaier marked this pull request as ready for review December 20, 2024 16:43
@blmaier
Copy link
Contributor Author

blmaier commented Dec 20, 2024

Hi @conda-forge/help-go, ready for reveiew!

The osx build has warnings about overlinking, are those a problem?
https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=1116673&view=logs&j=dff6ff7b-316b-540a-5923-739df25f7012&t=2582809e-c3dc-5a5f-d883-fd3c8f9139aa&l=1694

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants