Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FF #28680

Merged
merged 1 commit into from
Dec 23, 2024
Merged

Add FF #28680

merged 1 commit into from
Dec 23, 2024

Conversation

matthewfeickert
Copy link
Member

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
    • Library is static-only at the moment, so CFEP is followed to create ff-satic.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

Copy link
Contributor

Hi! This is the staged-recipes linter and your PR looks excellent! 🚀

@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Dec 22, 2024

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/ff/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipes/ff/meta.yaml:

  • ℹ️ The recipe is not parsable by parser conda-recipe-manager. The recipe can only be automatically migrated to the new v1 format if it is parseable by conda-recipe-manager.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12462901103. Examine the logs at this URL for more detail.

@matthewfeickert matthewfeickert marked this pull request as ready for review December 22, 2024 08:14
@matthewfeickert
Copy link
Member Author

@conda-forge/staged-recipes, ready for review! This is a fortran recipe.

Copy link
Contributor

To help direct your pull request to the best reviewers, please mention a topic-specifc team if your recipe matches any of the following: conda-forge/help-c-cpp, conda-forge/help-cdts, conda-forge/help-go, conda-forge/help-java, conda-forge/help-julia, conda-forge/help-nodejs, conda-forge/help-perl, conda-forge/help-python, conda-forge/help-python-c, conda-forge/help-r, conda-forge/help-ruby,or conda-forge/help-rust. Thanks!

- sed -i "s|/user/gj/lib/|$PREFIX/share/ff/|g" src/ff/ffinit.f
- sed -i "s|/usr/local/ff/|$PREFIX/share/ff/|g" src/ff/ffinit.f
# FIXME: Patch a path character length long enough to handle $PREFIX
- sed -i 's/128 path,fullname/4096 path,fullname/g' src/ff/ffinit.f
Copy link
Member Author

@matthewfeickert matthewfeickert Dec 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if there is a smarter / more effective way to try to deal with needing to get $PREFIX's very long length during conda-build into a variable in Fortran or not. Local tests with patched longer character length work, but then conda-build runs give ffopen: error: could not open $PREFIX/share/ff/ffwarn.dat.

* Add FF v2.0 from 1998 as ff-static
   - c.f. https://github.com/hep-packaging-coordination/ff
* FF is now archival software but is still required in areas of particle physics.
- test -f $PREFIX/share/ff/ffwarn.dat

- $FC ./src/ff/npointes.f -o npointes $FFLAGS -I$PREFIX/include/ff $LDFLAGS -lff
- ./npointes
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Things are now working as expected for Linux, but x86 macOS is now giving

 open: error: could not open /Users/runner/bld/ffwarn.dat                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                    
         adjust path in ffopen (ffinit.f)
ffwarn: warning cannot open ffwarn.dat with warning texts

indicating that fullname is not being set as $PREFIX/share/ff/ffwarn.dat as expected above.

Copy link
Member Author

@matthewfeickert matthewfeickert Dec 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The build example output also works as expected for

pixi run build-osx osx_arm64

It just seems to be x86 macOS that is having an issue now with the example.

@ocefpaf ocefpaf merged commit 8d39bc6 into conda-forge:main Dec 23, 2024
7 checks passed
@matthewfeickert matthewfeickert deleted the feat/add-ff-static branch December 24, 2024 04:24
@matthewfeickert
Copy link
Member Author

I messed up something in this PR such that I don't have maintainer privileges. Can conda-forge/ff-static-feedstock#1 get reviewed to try to fix this?

@matthewfeickert matthewfeickert mentioned this pull request Dec 24, 2024
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants