-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add FF #28680
Add FF #28680
Conversation
Hi! This is the staged-recipes linter and your PR looks excellent! 🚀 |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipes/ff/meta.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12462901103. Examine the logs at this URL for more detail. |
@conda-forge/staged-recipes, ready for review! This is a fortran recipe. |
To help direct your pull request to the best reviewers, please mention a topic-specifc team if your recipe matches any of the following: conda-forge/help-c-cpp, conda-forge/help-cdts, conda-forge/help-go, conda-forge/help-java, conda-forge/help-julia, conda-forge/help-nodejs, conda-forge/help-perl, conda-forge/help-python, conda-forge/help-python-c, conda-forge/help-r, conda-forge/help-ruby,or conda-forge/help-rust. Thanks! |
a5ae4f6
to
cc38a67
Compare
recipes/ff/meta.yaml
Outdated
- sed -i "s|/user/gj/lib/|$PREFIX/share/ff/|g" src/ff/ffinit.f | ||
- sed -i "s|/usr/local/ff/|$PREFIX/share/ff/|g" src/ff/ffinit.f | ||
# FIXME: Patch a path character length long enough to handle $PREFIX | ||
- sed -i 's/128 path,fullname/4096 path,fullname/g' src/ff/ffinit.f |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if there is a smarter / more effective way to try to deal with needing to get $PREFIX
's very long length during conda-build
into a variable in Fortran or not. Local tests with patched longer character length work, but then conda-build runs give ffopen: error: could not open $PREFIX/share/ff/ffwarn.dat
.
cc38a67
to
902a701
Compare
* Add FF v2.0 from 1998 as ff-static - c.f. https://github.com/hep-packaging-coordination/ff * FF is now archival software but is still required in areas of particle physics.
5c360d4
to
a3a7fac
Compare
- test -f $PREFIX/share/ff/ffwarn.dat | ||
|
||
- $FC ./src/ff/npointes.f -o npointes $FFLAGS -I$PREFIX/include/ff $LDFLAGS -lff | ||
- ./npointes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Things are now working as expected for Linux, but x86 macOS is now giving
open: error: could not open /Users/runner/bld/ffwarn.dat
adjust path in ffopen (ffinit.f)
ffwarn: warning cannot open ffwarn.dat with warning texts
indicating that fullname
is not being set as $PREFIX/share/ff/ffwarn.dat
as expected above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The build example output also works as expected for
pixi run build-osx osx_arm64
It just seems to be x86
macOS that is having an issue now with the example.
I messed up something in this PR such that I don't have maintainer privileges. Can conda-forge/ff-static-feedstock#1 get reviewed to try to fix this? |
Checklist
ff-satic
.url
) rather than a repo (e.g.git_url
) is used in your recipe (see here for more details).