Add dipy recipe. #308

arokem · 2016-04-10T18:20:40Z

No description provided.

conda-forge-admin · 2016-04-10T18:20:43Z

Hi! This is the friendly conda-forge-admin automated user.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/dipy) and found it was in an excellent condition.

arokem · 2016-04-10T18:21:11Z

Replaces #307

ocefpaf · 2016-04-10T18:22:53Z

recipes/dipy/meta.yaml

+requirements:
+  build:
+    - python
+    - numpy


I suspect that, since this requires numpy and cython, it uses the numpy ABI. If That is true you need to use: numpy x.x in the build and run fields.

arokem · 2016-04-10T18:30:47Z

This one depends on #284

conda-forge-linter · 2016-05-10T14:31:27Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/dipy) and found it was in an excellent condition.

arokem · 2016-05-10T14:41:51Z

Should we worry about this? https://travis-ci.org/conda-forge/staged-recipes/jobs/129156365#L4862

jakirkham · 2016-05-10T14:43:38Z

We intentionally downgrade conda-build. See this PR ( #488 ) and related cross refs for details.

arokem · 2016-05-10T14:44:50Z

I'm letting this run, but I should probably reduce testing here.

arokem · 2016-05-12T13:18:51Z

Does anyone have any thoughts on why we are getting this conflict?

ocefpaf · 2016-05-12T13:26:17Z

recipes/dipy/meta.yaml

+requirements:
+  build:
+    - python
+    - numpy >=1.7.1


You don't really need this. We build only numpy 1.9 and above.

Actually, I check setup.py and I believe you need numpy x.x to ensure the numpy used in the build will be installed at run time.

arokem · 2016-05-12T14:11:25Z

Like so?

ocefpaf · 2016-05-12T14:14:18Z

recipes/dipy/meta.yaml

+    - numpy x.x
+    - scipy
+    - nibabel
+    - cython


Do you need cython as a run dependency?

Good catch. Probably not.

On Thu, May 12, 2016 at 7:14 AM, Filipe notifications@github.com wrote:

In recipes/dipy/meta.yaml
#308 (comment)
:

+build:

number: 0

script: python setup.py install

+requirements:

build:

python

numpy x.x

nibabel

cython

run:

python

numpy x.x

scipy

nibabel

cython

Do you need cython as a run dependency?

—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/conda-forge/staged-recipes/pull/308/files/11806b214f840b1bb21af55204299c8d7a715980#r63027341

grlee77 · 2016-05-12T14:23:46Z

IIRC dipy also compiles using OpenMP if available. To enable it (at least for osx and linux),you can add
- gcc # [unix] to the build requirements
- libgcc # [unix] to the run requirements

ocefpaf · 2016-05-12T14:25:25Z

@grlee77 I prefer the more honest # [not win] 😄

grlee77 · 2016-05-12T14:32:01Z

Also, I am not an export on the windows builds, but I think that will require something like:

features:
   - vc9                                 # [win and py27]
   - vc10                                # [win and py34]
   - vc14                                # [win and py35]

to appear within the build section. (you can see an example in #453)

grlee77 · 2016-05-12T14:37:25Z

The CircleCI build failures are because the VTK package for conda-forge hasn't yet been merged and the default channel only has a Python 2.7 one. So Python 3.4 and 3.5 won't build until #453 is completed.

grlee77 · 2016-05-12T14:44:17Z

Alternatively, if you really want this merged asap, you could remove VTK from the runtime dependencies (I believe it is optional). It could be added back in the feedstocks after vtk is merged.

conda-forge-linter · 2016-05-12T15:40:59Z

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/dipy) and found some lint.

Here's what I've got...

For recipes/dipy:

Selectors are suggested to take a <two spaces>#<one space>[<expression>] form.

arokem · 2016-05-12T15:41:56Z

Ah yes, VTK on Python 3. Thanks @grlee77 for the pointer (and thanks for the work on #453. Let's get this in without VTK for now, and add it later on once that's settled.

conda-forge-linter · 2016-05-12T15:42:53Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/dipy) and found it was in an excellent condition.

arokem · 2016-05-12T15:45:20Z

Is there a way to say something like "add VTK to run, but only on Python 3"?

Might this be the way to achieve that?

- vtk [py34 or py35]

ocefpaf · 2016-05-12T15:46:33Z

@arokem it can be vtk # [py3k]

arokem · 2016-05-12T15:48:07Z

Sorry - got myself confused there. Need VTK, but only on python 2. Maybe this will do it.

ocefpaf · 2016-05-12T15:48:52Z

recipes/dipy/meta.yaml

@@ -32,6 +32,7 @@ requirements:
    - scikit-learn
    - matplotlib
    - libgcc  # [not win]
+    - vtk  # [py27]


grlee77 · 2016-05-12T20:39:07Z

The Travis CI is a time-out, but what is odd is that if you grep for TEST END: dipy, it does seems to have completed all 6 dipy builds (numpy 1.10, 1.11) * (python 2.7, 3.4, 3.5).

What I don't understand is why it then tries to build glueviz? see the Building glueviz-0.7.3-py27_0 near the end of the log

grlee77 · 2016-05-14T17:06:51Z

I think Travis should pass now if restarted.

jakirkham · 2016-05-14T17:20:41Z

The Travis CI is a time-out, but what is odd is that if you grep for TEST END: dipy, it does seems to have completed all 6 dipy builds (numpy 1.10, 1.11) * (python 2.7, 3.4, 3.5).

There seems to be an issue generating feedstocks ( #619 ). As a result, there are a bunch recipes still included in staged-recipes that need to be converted. Once that is resolved, we would be more than happy to restart and expect this will pass.

conda-forge-linter · 2016-05-15T00:40:46Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/dipy, recipes/lua-5.1, recipes/pycapnp) and found it was in an excellent condition.

arokem · 2016-05-15T00:44:08Z

OK. For now, I have rebased this on master, which included these other recipes in, and I will rebase again once that's resolved.

…run time

…cc for omp.

conda-forge-linter · 2016-05-18T14:18:33Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/dipy) and found it was in an excellent condition.

arokem · 2016-05-18T14:18:47Z

Rebased again. I believe this should be ready to go now?

ocefpaf · 2016-05-18T17:30:16Z

LGTM

jakirkham · 2016-05-18T18:05:07Z

recipes/dipy/meta.yaml

+extra:
+  recipe-maintainers:
+    - arokem
+    - garyfallidis


I'm sure you guys have already discussed this, but please let us know whether it is ok to have you as a maintainer on the dipy recipe at conda-forge, @Garyfallidis.

Garyfallidis · 2016-05-18T20:59:20Z

All good here. But please replace nipy.org/dipy to dipy.org if possible.

grlee77 · 2016-05-18T21:38:31Z

@arokem, @Garyfallidis
you may already be aware of this, but thought I would mention it as I forgot the forking step my first time around...

Since this has already been merged the procedure to change the recipe now is to fork the feedstock from https://github.com/conda-forge/dipy-feedstock, create a branch with the desired change and then submit a PR there. (If you are just changing the website link, I think you can skip Travis and Appveyor by adding [skip ci] at the end of the commit message)

ocefpaf reviewed Apr 10, 2016
View reviewed changes

grlee77 mentioned this pull request Apr 14, 2016

add mayavi and vtk #285

Closed

arokem force-pushed the dipy branch from 4f471d7 to dd5d77f Compare May 10, 2016 14:31

ocefpaf reviewed May 12, 2016
View reviewed changes

recipes/dipy/meta.yaml

@@ -32,6 +32,7 @@ requirements:

- scikit-learn

- matplotlib

- libgcc # [not win]

- vtk # [py27]

Copy link

Member

ocefpaf May 12, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

arokem force-pushed the dipy branch from 1e47abd to c0ad8ba Compare May 15, 2016 00:40

arokem added 11 commits May 18, 2016 07:18

Add dipy recipe.

bcda84e

Specify the BSD license.

a79d7c8

Remove bld.bat file, no longer needed.

d084026

Specify numpy version requirements.

4bed262

Remove full test run.

f188da2

Use numpy x.x so that numpy used in the build will be installed at …

075cb4b

…run time

Remove cython as a run dependency.

0734735

Add features to build (for Windows). Remove VTK run dependence. Add g…

2c8dc20

…cc for omp.

Linting and also selecting not win as relevant.

416a765

Add VTK for Python 2.7 (for now).

45fa6b5

Remove features.

ebf30cb

arokem force-pushed the dipy branch from c0ad8ba to ebf30cb Compare May 18, 2016 14:18

ocefpaf merged commit ebf6066 into conda-forge:master May 18, 2016

jakirkham reviewed May 18, 2016
View reviewed changes

Add dipy recipe. #308

Add dipy recipe. #308

Conversation

arokem commented Apr 10, 2016

conda-forge-admin commented Apr 10, 2016

arokem commented Apr 10, 2016

ocefpaf Apr 10, 2016

Choose a reason for hiding this comment

arokem commented Apr 10, 2016

conda-forge-linter commented May 10, 2016

arokem commented May 10, 2016

jakirkham commented May 10, 2016

arokem commented May 10, 2016

arokem commented May 12, 2016

ocefpaf May 12, 2016

Choose a reason for hiding this comment

ocefpaf May 12, 2016

Choose a reason for hiding this comment

arokem commented May 12, 2016

ocefpaf May 12, 2016

Choose a reason for hiding this comment

arokem May 12, 2016

Choose a reason for hiding this comment

grlee77 commented May 12, 2016

ocefpaf commented May 12, 2016

grlee77 commented May 12, 2016

grlee77 commented May 12, 2016

grlee77 commented May 12, 2016

conda-forge-linter commented May 12, 2016

arokem commented May 12, 2016

conda-forge-linter commented May 12, 2016

arokem commented May 12, 2016

ocefpaf commented May 12, 2016

arokem commented May 12, 2016

ocefpaf May 12, 2016

Choose a reason for hiding this comment

grlee77 commented May 12, 2016

grlee77 commented May 14, 2016

jakirkham commented May 14, 2016 • edited Loading

conda-forge-linter commented May 15, 2016

arokem commented May 15, 2016

conda-forge-linter commented May 18, 2016

arokem commented May 18, 2016

ocefpaf commented May 18, 2016

jakirkham May 18, 2016

Choose a reason for hiding this comment

Garyfallidis commented May 18, 2016

grlee77 commented May 18, 2016

jakirkham commented May 14, 2016 •

edited

Loading