Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added tornado, certifi and ssl_match_hostname. #320

Merged
merged 1 commit into from
Apr 12, 2016
Merged

Added tornado, certifi and ssl_match_hostname. #320

merged 1 commit into from
Apr 12, 2016

Conversation

pelson
Copy link
Member

@pelson pelson commented Apr 12, 2016

Tornado is a Python web framework and asynchronous networking library, originally developed at FriendFeed. By using non-blocking network I/O, Tornado can scale to tens of thousands of open connections, making it ideal for long polling, WebSockets, and other applications that require a long-lived connection to each user.


Certifi is a carefully curated collection of Root Certificates for validating the trustworthiness of SSL certificates while verifying the identity of TLS hosts. It has been extracted from the Requests project.


The Secure Sockets Layer is only actually secure
if you check the hostname in the certificate returned
by the server to which you are connecting,
and verify that it matches to hostname
that you are trying to reach.

Brandon Craig Rhodes is merely the packager of ssl_match_hostname;
the actual code inside comes from Python 3.5 with small changes for
portability.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly conda-forge-admin automated user.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/tornado, recipes/certifi, recipes/ssl_match_hostname) and found it was in an excellent condition.


extra:
recipe-maintainers:
- dan-blanchard
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ping @dan-blanchard - you contributed certifi to conda/conda-recipes and so assumed you would want to know about this. If you'd rather not be named, I'd happily take your name off the list.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problems if you'd rather be removed, but I'll merge this PR for now.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please take my name off this one. All I did was run conda skeleton on it. 😄

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deal. 😄

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just so I understand, if his name is removed from this list, will that remove him from the team when the feedstock update is run?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It used to, but now it just warns:

https://travis-ci.org/conda-forge/conda-forge.github.io/jobs/122567637:

Running command: ['python', '/home/travis/build/conda-forge/conda-forge.github.io/scripts/update_teams.py', './feedstocks_repo/feedstocks']
AN OLD MEMBER (dan-blanchard) NEEDS TO BE REMOVED FROM conda-forge/certifi-feedstock
THE conda-forge-webservices TEAM NEEDS TO BE REMOVED.
Keeping  Core
Keeping  all-members
Keeping  conda-forge.github.io

The message about the conda-forge-webservices team also needs updating.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm...interesting. I added an issue ( conda-forge/conda-forge.github.io#84 ) so we can track this.

@pelson
Copy link
Member Author

pelson commented Apr 12, 2016

Hi @bdarnell, @kennethreitz and @brandon-rhodes,

conda-forge is a community led packaging system for use with conda, and I just wanted to let you know that we are adding tornado, certifi and ssl_match_hostname to the list of packaged software on conda-forge.

The conda-forge infrastructure revolves around the idea of a feedstock, which is just a git repo containing a conda recipe (the build instructions) and automatically generated CI scripts necessary to build the recipe on Linux, OSX and Windows where appropriate. After merging this PR, tornado, certifi and ssl_match_hostname will each be given their own feedstock. The built conda distribution will be automatically uploaded to the to the conda-forge channel once the feedstock successfully runs its CI.

After an auditing process (yet to be fully defined), we hope packages submitted here will be included in the defaults channel distributed by Continuum, but in the meantime, everybody can benefit from these distributions by adding conda-forge as a conda channel.

We would love for you, and anybody else you can recommend, to be part of the tornado-feedstock, certifi-feedstock and ssl_match_hostname-feedstock maintenance teams. Adding somebody to the team is simply a matter of adding your github handle to recipe-maintainers in the recipe/meta.yaml of the feedstock (i.e. it is part of the metadata itself) - conda-forge's automatic team management will take care of the rest and give you write access to the feedstock. Being part of the maintainer's team typically involves changing the version string when a new release of your software is made, responding to issues raised by users, as well as merging the occasional PR when automatic updates to the CI scripts are proposed.

If you'd like to be part of the feedstock maintainers list, but would rather not raise the PR yourself, just let me know and I'd be happy to update recipe-maintainers on your behalf.

Thanks again for working on such useful libraries!

@pelson pelson merged commit bb2de63 into conda-forge:master Apr 12, 2016
@pelson pelson deleted the tornado branch April 12, 2016 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants