Add recipe for Gensim #3225

souravsingh · 2017-06-30T11:55:22Z

Adds a new recipe for Gensim.

conda-forge-linter · 2017-06-30T11:55:27Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/gensim) and found it was in an excellent condition.

mariusvniekerk · 2017-07-06T12:42:12Z

recipes/gensim/meta.yaml

+  requires:
+    - nose
+    - testfixtures
+    - unittest


unittest is a builtin

mariusvniekerk · 2017-07-06T12:45:57Z

recipes/gensim/meta.yaml

+  build:
+    - python
+    - setuptools
+    - numpy >=1.3


Since gensim uses cython, i would change this to

- numpy x.x - cython

and change the numpy section in the run area too.

This will build you a version of gensim that is compatible with the numpy ABI for the versions that conda forge supports

mariusvniekerk · 2017-07-07T04:55:18Z

So generally we don't run the unit test suite of a library as part of conda forge packaging. Instead we validate that things are importable and correctly linked. Running unit tests is typically done upstream in the project itself.

menshikh-iv · 2017-07-07T05:00:33Z

recipes/gensim/meta.yaml

+    - setuptools
+    - numpy x.x
+    - cython
+    - scipy >=0.7.0


Please use numpy/scipy versions from develop branch

mariusvniekerk · 2017-07-07T04:59:49Z

recipes/gensim/meta.yaml

+  run:
+    - python
+    - numpy x.x
+    - cython


cython is probably not needed as a runtime dependency

mariusvniekerk · 2017-07-07T05:02:11Z

recipes/gensim/meta.yaml

+
+test:
+  requires:
+    - nose


Its probably sufficient initially to have

imports: - gensim - gensim.foo

for all the standard importable modules

souravsingh · 2017-07-07T11:45:56Z

@mariusvniekerk @menshikh-iv The tests on the recipe have passed, but I remember @tmylk saying that the whole test suite must be run in the recipe. Should we go ahead with running the import tests?

souravsingh · 2017-07-12T10:50:27Z

Ping @menshikh-iv

tmylk · 2017-07-12T11:29:58Z

If the gensim suite tests of the assembled conda recipe fail then the package shouldn't be released.

souravsingh · 2017-07-14T09:42:23Z

Thanks @tmylk. I will be replacing the import tests with the full gensim tests.

souravsingh · 2017-07-18T12:45:36Z

@menshikh-iv The test suite is not running due to the unittest2 import. Do we replace all the unittest2 imports with unittest?

piskvorky · 2017-07-20T02:24:08Z

recipes/gensim/meta.yaml

+    - python
+    - setuptools
+    - numpy >=1.11.3
+    - cython


Why is this needed? I don't think cython is a dependency of gensim.

piskvorky · 2017-07-20T02:26:29Z

recipes/gensim/meta.yaml

+  license_file: COPYING
+  license_family: LGPL
+  summary: 'A library for topic modelling and document indexing'
+  description: |


Please use the official tagline and description of gensim (see https://github.com/RaRe-Technologies/gensim).

piskvorky

Minor doc nitpicks.

piskvorky · 2017-07-20T15:42:45Z

recipes/gensim/meta.yaml

+  license: LGPL 3.0
+  license_file: COPYING
+  license_family: LGPL
+  summary: 'Topic Modelling in Python'


Tagline = Topic Modelling for Humans.

piskvorky · 2017-07-20T15:43:40Z

recipes/gensim/meta.yaml

+  description: |
+    Gensim is a Python library for topic modelling, document indexing 
+    and similarity retrieval with large corpora. 
+    Target audience is the natural language processing(NLP) 


Missing space before the opening bracket.

piskvorky · 2017-07-20T15:44:46Z

recipes/gensim/meta.yaml

+  license_file: COPYING
+  license_family: LGPL
+  summary: 'Topic Modelling in Python'
+  description: |


The | is some specific formatter?

conda-forge-linter · 2017-08-24T13:03:12Z

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/gensim) and found some lint.

Here's what I've got...

For recipes/gensim:

Selectors are suggested to take a <two spaces>#<one space>[<expression>] form.

conda-forge-linter · 2017-08-24T13:22:28Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/gensim) and found it was in an excellent condition.

souravsingh · 2017-08-27T10:08:44Z

@ocefpaf Is it possible to restart Appveyor builds for the recipe? The Python 2.7 build has failed due to a ConnectionError

ocefpaf · 2017-08-27T11:52:59Z

Done. But you can also do that by closing and opening the PR.

souravsingh · 2017-08-29T14:20:24Z

@piskvorky The recipe is now ready for deployment as a feedstock. The recipe currently supports Linux and Windows 64-bit, since it might create problems for Windows 32-bit if they wish to run the Gensim for a larger corpus.

I have skipped support for OSX for now since Travis times out everytime when we run the nosetests command. I suggest merging the recipe for now

piskvorky · 2017-08-29T17:31:01Z

Thanks, but I don't have merge rights in this repo. This is for @menshikh-iv -- what is the merging / deployment process here?

souravsingh · 2017-08-29T18:02:45Z

@piskvorky First, The PR will be merged by one of the reviewers from conda-forge organization(Filipe handles most of the merging stuff). Once the recipe is merged, The conda-smithy will start creating a feedstock repository for the recipe, something similar to this repository- https://github.com/conda-forge/tensorflow-feedstock and the built tarballs will be uploaded to the conda-forge channel, from where the users can download the tarball directly.

mariusvniekerk · 2017-08-30T13:23:36Z

@ocefpaf @ericdill @jakirkham Is this ready to go?

ocefpaf · 2017-08-30T13:55:46Z

We are having some trouble in master with the feedstock creation. We'll resume merging PRs as soon as that is solved. (I'll look into the problem soon.)

menshikh-iv · 2017-09-01T13:55:57Z

Ignoring MacOS looks suspicious, but we can resolve it later.
LGTM for me, good job @souravsingh👍

souravsingh · 2017-09-01T14:01:49Z

@ocefpaf Is the recipe ready to merge?

souravsingh · 2017-09-01T14:43:28Z

@ocefpaf The Gensim doesn't support Python 3.4. It only supports Python 2.7, 3.5 and 3.6

ocefpaf · 2017-09-01T14:48:04Z

@ocefpaf The Gensim doesn't support Python 3.4. It only supports Python 2.7, 3.5 and 3.6

Don't worry about the pre-selector there. Conda-forge does not build Python 3.4. (I added it for reasons 😉)

However, if py34 is not really support you need to add a skip statement.

menshikh-iv · 2017-09-01T15:24:48Z

The Gensim doesn't support Python 3.4. It only supports Python 2.7, 3.5 and 3.6

Incorrect. Gensim supports all versions >= 2.7.

ocefpaf · 2017-09-01T15:26:41Z

Incorrect. Gensim supports all versions >= 2.7.

Thanks @menshikh-iv. Good to know!

souravsingh · 2017-09-01T17:27:12Z

My bad, I thought Gensim doesn't support Python 3.4 since there is no build matrix for py3.4 in Travis. Thanks for the info @menshikh-iv.

Add recipe for Gensim

4f80272

mariusvniekerk reviewed Jul 6, 2017

View reviewed changes

recipes/gensim/meta.yaml Outdated

requires:

- nose

- testfixtures

- unittest

Copy link

Member

mariusvniekerk Jul 6, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unittest is a builtin

mariusvniekerk reviewed Jul 6, 2017

View reviewed changes

Update meta.yaml

1b25b9c

souravsingh mentioned this pull request Jul 6, 2017

Adding a conda-forge recipe for Gensim piskvorky/gensim#892

Closed

souravsingh added 2 commits July 7, 2017 03:32

Add additional dependencies

d96feb8

Make fixes

f88123a

menshikh-iv reviewed Jul 7, 2017

View reviewed changes

mariusvniekerk reviewed Jul 7, 2017

View reviewed changes

souravsingh added 2 commits July 7, 2017 16:52

Update minimum NumPy and Scipy vers and fix tests

321e1bb

Update meta.yaml

62aef3d

souravsingh added 8 commits July 14, 2017 15:16

Fix test

454a9a5

Fix problems

b28f0e8

Update meta.yaml

bb4ecc5

Update meta.yaml

7831ca8

Update meta.yaml

22c08c7

Small fix

74bda87

Fix test requirements

b6a7a3e

Update meta.yaml

118e8b4

souravsingh mentioned this pull request Jul 19, 2017

Remove unittest2 imports piskvorky/gensim#1490

Merged

piskvorky suggested changes Jul 20, 2017

View reviewed changes

Remove cython and update the about sections

e47dff8

piskvorky suggested changes Jul 20, 2017

View reviewed changes

Skip builds entirely for OSX and Windows

3b6612f

Fix formatting

61854a0

souravsingh added 2 commits August 26, 2017 10:20

Remove keras from test requires

4df111d

Test support for win64 platform

45218e8

souravsingh closed this Aug 27, 2017

souravsingh reopened this Aug 27, 2017

souravsingh closed this Aug 28, 2017

souravsingh reopened this Aug 28, 2017

Update meta.yaml

1bb5ce8

add the skip statement

53a16a2

souravsingh closed this Sep 3, 2017

souravsingh reopened this Sep 3, 2017

ocefpaf merged commit 95eefab into conda-forge:master Sep 4, 2017

souravsingh deleted the add-gensim branch September 4, 2017 13:30

Add recipe for Gensim #3225

Add recipe for Gensim #3225

Conversation

souravsingh commented Jun 30, 2017

conda-forge-linter commented Jun 30, 2017

Choose a reason for hiding this comment

mariusvniekerk Jul 6, 2017 • edited Loading

Choose a reason for hiding this comment

mariusvniekerk commented Jul 7, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

souravsingh commented Jul 7, 2017 • edited Loading

souravsingh commented Jul 12, 2017

tmylk commented Jul 12, 2017

souravsingh commented Jul 14, 2017

souravsingh commented Jul 18, 2017

Choose a reason for hiding this comment

piskvorky Jul 20, 2017 • edited Loading

Choose a reason for hiding this comment

piskvorky left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

piskvorky Jul 20, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

conda-forge-linter commented Aug 24, 2017

conda-forge-linter commented Aug 24, 2017

souravsingh commented Aug 27, 2017 • edited Loading

ocefpaf commented Aug 27, 2017

souravsingh commented Aug 29, 2017 • edited Loading

piskvorky commented Aug 29, 2017 • edited Loading

souravsingh commented Aug 29, 2017 • edited Loading

mariusvniekerk commented Aug 30, 2017

ocefpaf commented Aug 30, 2017

menshikh-iv commented Sep 1, 2017

souravsingh commented Sep 1, 2017

souravsingh commented Sep 1, 2017

ocefpaf commented Sep 1, 2017

menshikh-iv commented Sep 1, 2017 • edited Loading

ocefpaf commented Sep 1, 2017

souravsingh commented Sep 1, 2017 • edited Loading

mariusvniekerk Jul 6, 2017 •

edited

Loading

souravsingh commented Jul 7, 2017 •

edited

Loading

piskvorky Jul 20, 2017 •

edited

Loading

piskvorky Jul 20, 2017 •

edited

Loading

souravsingh commented Aug 27, 2017 •

edited

Loading

souravsingh commented Aug 29, 2017 •

edited

Loading

piskvorky commented Aug 29, 2017 •

edited

Loading

souravsingh commented Aug 29, 2017 •

edited

Loading

menshikh-iv commented Sep 1, 2017 •

edited

Loading

souravsingh commented Sep 1, 2017 •

edited

Loading