Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add patchelf #357

Merged
merged 1 commit into from
Apr 14, 2016
Merged

Add patchelf #357

merged 1 commit into from
Apr 14, 2016

Conversation

jakirkham
Copy link
Member

Adds a recipe to build patchelf. Based off of the recipe from conda-recipes. Cleaned up a bit to fit into conda-forge.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly conda-forge-admin automated user.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/patchelf) and found some lint.

Here's what I've got...

For recipes/patchelf:

  • The recipe could do with some maintainers listed in the "extra/recipe-maintainers" section.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly conda-forge-admin automated user.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/patchelf) and found it was in an excellent condition.

@jakirkham
Copy link
Member Author

@mjuric @tpn, we are adding patchelf to conda-forge. This is the community packaging system for use with conda. Packages built here are built with CI and deployed to the conda-forge channel automatically after committing on master of a feedstock (a repo with the recipe plus automatically maintained CI scripts). Eventually, packages submitted here will be included in the defaults channel after some auditing process as mentioned. If there is anything here that you see is off or needs to be fixed, please let me know. If you would like to have access to the patchelf feedstock/recipe (not yet generated), I would happily add you to the maintainers list so you can have commit privileges for this recipe. This would be useful for updating the version for instance. Thanks again for helping put together this useful recipe.

@jakirkham
Copy link
Member Author

@dan-blanchard, I saw you also contributed to this recipe for patchelf. Thanks for doing that. Would you have any interest in being added as a maintainer?

@pelson pelson merged commit 96e8c3a into conda-forge:master Apr 14, 2016
@mjuric
Copy link
Contributor

mjuric commented Apr 14, 2016

@jakirkham Thanks, I'd be happy to help maintaining. The updated patchelf had been working well for us.

@jakirkham
Copy link
Member Author

Excellent, thanks @mjuric. I will add you.

I bumped the version to 0.9 as that was released at the end of February and is not yet in the defaults channel so this is the newest version of patchelf.

@jakirkham
Copy link
Member Author

This PR ( conda-forge/patchelf-feedstock#1 ) will add you, @mjuric, as a maintainer once merged. As this is your first time being added as a maintainer, you will receive an invite to join conda-forge. Once accepted, you will be added to the patchelf team. This will give you commit privileges over this feedstock (repo). This way you can propose maintenance fixes and version updates. Just keep in mind that you must fork the feedstock (repo) and PR changes back here. Any other feedstocks (repos) that you add yourself or others add you (with permission of course) will automatically add you to the proper maintenance teams and give you commit privileges over those feedtsocks (repos) automatically and will require no action on your part going forward.

If you have any questions, please don't hesitate to ask. Welcome to conda-forge. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants