Add (optional) dependencies of newer tpot #4708
Conversation
|
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/tpot:
For recipes/update_checker:
|
…dep (pkg_resources)
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
bollwyvl
changed the title
|
Great, |
bollwyvl
changed the title
recipes/scikit-mdr/meta.yaml
Outdated
| MDR currently only works with categorical features and supports both binary | ||
| classification and regression problems. We are working on expanding the | ||
| algorithm to cover more problem types and provide more convenience features. | ||
| doc_url: http://simplejson.readthedocs.io/ |
| url: https://pypi.io/packages/source/{{ name[0] }}/{{ name }}/{{ name }}-{{ version }}.tar.gz | ||
| sha256: {{ sha256 }} | ||
|
|
||
| build: |
There was a problem hiding this comment.
Can this be noarch: python?
http://conda-forge.readthedocs.io/en/latest/meta.html#building-noarch-packages
| url: https://pypi.io/packages/source/{{ name[0] }}/{{ name }}/{{ name }}-{{ version }}.tar.gz | ||
| sha256: {{ sha256 }} | ||
|
|
||
| build: |
There was a problem hiding this comment.
Also possibly noarch: python?
There was a problem hiding this comment.
also works locally
| license: MIT | ||
| license_family: MIT | ||
| # TODO: upstream a PR to add LICENSE to MANIFEST.in | ||
| # license_file: LICENSE |
There was a problem hiding this comment.
Please submit the PR and list it as a comment in this recipe. Also:
conda-forge.github.io/docs/meta.html#packaging-the-license-manually
| about: | ||
| home: https://pypi.python.org/pypi/stopit | ||
| license: GPL-3.0 | ||
| license_family: GPL |
There was a problem hiding this comment.
Could you submit an issue upstream asking them to include a license file in the source distribution and put a link to the issue as a comment here.
| url: https://pypi.io/packages/source/{{ name[0] }}/{{ name }}/{{ name }}-{{ version }}.tar.gz | ||
| sha256: {{ sha256 }} | ||
|
|
||
| build: |
recipes/scikit-mdr/meta.yaml
Outdated
| recipe-maintainers: | ||
| - bollwyvl | ||
| - bryketos | ||
| - EpistasisLab |
There was a problem hiding this comment.
at request of @rhiever, i've added @EpistasisLab as a maintainer, which is an organization (in this case, a lab at Penn)
EpistasisLab/scikit-rebate#31 (comment)
This does seem like a great feature for certain cases, but maybe not in all, depending on how the org in question is structured... figured I'd let CI chew on it, but any formal guidance would be good!
There was a problem hiding this comment.
I can provide a list of specific GitHub names to use in place of the org if needed/desired.
There was a problem hiding this comment.
There was a problem hiding this comment.
updated with list given.
|
We don’t have support for listing orgs as maintainers currently. |
|
yeah, didn't even know how that might work, as i don't think an org can join a team, for example. either way, that's a good number of people! |
|
@bollwyvl - can you confirm that all of the people listed as co-maintainers are ok being listed? If they are, I'm happy to merge. |
| extra: | ||
| recipe-maintainers: | ||
| - bollwyvl | ||
| - lacava |
There was a problem hiding this comment.
@lacava, can you comment here that you're okay being added as a co-maintainer to skrebate and scikit-mdr?
recipes/scikit-mdr/meta.yaml
Outdated
| recipe-maintainers: | ||
| - bollwyvl | ||
| - lacava | ||
| - pschmitt52 |
There was a problem hiding this comment.
@pschmitt52, can you comment here that you're okay being added as a co-maintainer to skrebate and scikit-mdr?
recipes/scikit-mdr/meta.yaml
Outdated
| - lacava | ||
| - pschmitt52 | ||
| - rhiever | ||
| - ryanurbs |
There was a problem hiding this comment.
@ryanurbs, can you comment here that you're okay being added as a co-maintainer to skrebate and scikit-mdr?
recipes/scikit-mdr/meta.yaml
Outdated
| - pschmitt52 | ||
| - rhiever | ||
| - ryanurbs | ||
| - weixuanfu |
There was a problem hiding this comment.
@weixuanfu, can you comment here that you're okay being added as a co-maintainer to skrebate and scikit-mdr?
recipes/scikit-mdr/meta.yaml
Outdated
| - bollwyvl | ||
| - lacava | ||
| - pschmitt52 | ||
| - rhiever |
There was a problem hiding this comment.
@rhiever, can you comment here that you're okay being added as a co-maintainer to skrebate and scikit-mdr?
|
Two out of five ain't bad... and it's easy to add folks on small PRs after the fact. Will pull the non-repliers tomorrow some time... |
|
Ok, updated with those maintainers who confirmed for |
|
Great. I'll merge once the CI finishes. |
|
Huzzah! |
Been meaning to get around to this for some time, but redid them from scratch...