-
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add recipes for trio and async_generator #5080
Conversation
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/async_generator:
For recipes/trio:
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge/staged-recipes I believe this is ready for review/merge. 👍 |
recipes/async_generator/meta.yaml
Outdated
license_family: MIT | ||
license_file: '' | ||
summary: Async generators and context managers for Python 3.5+ | ||
description: ".. image:: https://img.shields.io/badge/chat-join%20now-blue.svg\n :target: https://gitter.im/python-trio/general\n :alt: Join chatroom\n\n.. image:: https://img.shields.io/badge/docs-read%20now-blue.svg\n\ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is unreadable. I would just take a paragraph or 2 and avoid the examples
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed, thanks
I agree, this was generated by conda build. Will change it later.
Em sáb, 3 de fev de 2018 13:19, Isuru Fernando <notifications@github.com>
escreveu:
… ***@***.**** commented on this pull request.
------------------------------
In recipes/async_generator/meta.yaml
<#5080 (comment)>
:
> + - setuptools
+ run:
+ - python
+
+test:
+ imports:
+ - async_generator
+ - async_generator._tests
+
+about:
+ home: https://github.com/python-trio/async_generator
+ license: MIT
+ license_family: MIT
+ license_file: ''
+ summary: Async generators and context managers for Python 3.5+
+ description: ".. image:: https://img.shields.io/badge/chat-join%20now-blue.svg\n <https://img.shields.io/badge/chat-join%20now-blue.svg%5Cn> :target: https://gitter.im/python-trio/general\n :alt: Join chatroom\n\n.. image:: https://img.shields.io/badge/docs-read%20now-blue.svg\n\ <https://img.shields.io/badge/docs-read%20now-blue.svg%5Cn%5C>
This is unreadable. I would just take a paragraph or 2 and avoid the
examples
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#5080 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABCO_L_7bkZj9rsclqsoIf7MHZozLiucks5tRHkIgaJpZM4R3gLi>
.
|
recipes/async_generator/meta.yaml
Outdated
home: https://github.com/python-trio/async_generator | ||
license: MIT | ||
license_family: MIT | ||
license_file: '' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we get a license?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Opened python-trio/async_generator#11 and added a link to the recipe so we can fix that in the next release.
@CJ-Wright @isuruf ready for another review. |
cc @conda-forge/staged-recipes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comments that should not prevent this from getting merged.
recipes/async_generator/meta.yaml
Outdated
version: '{{ version }}' | ||
|
||
source: | ||
fn: '{{ name }}-{{ version }}.tar.gz' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line can be dropped.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
recipes/async_generator/meta.yaml
Outdated
|
||
build: | ||
number: 0 | ||
script: python setup.py install --single-version-externally-managed --record=record.txt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are moving to script: python -m pip install --no-deps --ignore-installed .
. See conda-forge/conda-forge.github.io#518
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
license: MIT | ||
license_family: MIT | ||
# license file not available on sdist yet: https://github.com/python-trio/async_generator/pull/11 | ||
license_file: '' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You don't need the empty field but that does not hurt.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I prefer to leave it there so we fill it with the license file in the next release
recipes/trio/meta.yaml
Outdated
license_family: MIT | ||
license_file: LICENSE | ||
summary: An async/await-native I/O library for humans and snake people | ||
description: ".async/await-native I/O library for Python. Like all async libraries,\n |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kind of big and with some escape characters that I don't think are needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
@nicoddemus What do you want to do about the AppVeyor failure?
|
Should I make |
You can leave the |
Ahh good idea, done! |
Thanks @ocefpaf! |
No description provided.