Add SunPy, Glymur and wcsaxes #605
Conversation
|
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/sunpy:
|
|
@Cadair you don't need the separate build scripts in your case - you can just add the following line in your YAML file: |
|
And you can add the extra flags for Sunpy (but you don't need separate build scripts) |
|
handy! you know how to skip python 3 builds?! |
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
|
Someone more knowledgeable than me can comment on it, but you might be able to add something like in the build section (total guess). The documentation is pretty sparse: http://conda.pydata.org/docs/building/meta-yaml.html#skipping-builds |
|
ping @quintusdias you might find this interesting! |
|
Thanks @Cadair for the PR and @astrofrog for the review! |
|
|
||
| build: | ||
| number: 0 | ||
| script: python setup.py install |
There was a problem hiding this comment.
When setuptools is available you can use
script: python setup.py install --single-version-externally-managed --record record.txtThat makes the package more "external packager manager friendly."
There was a problem hiding this comment.
@astrofrog you got any idea how they interact with astropy_helpers?
There was a problem hiding this comment.
No, but make sure you add --offline --no-git for the sunpy build, and we'll find out! (sorry just saw you already have those - so just try combining with the above flags)
| - setuptools | ||
| - numpy >=1.7.0 | ||
| - lxml >=2.3.2 | ||
| - mock |
There was a problem hiding this comment.
Is mock a build and run dependency? Or is it just for tests?
There was a problem hiding this comment.
it's probably only a build dep.
There was a problem hiding this comment.
Just for tests. I should remove that...
On Fri, May 13, 2016 at 11:59 AM, Filipe notifications@github.com wrote:
In recipes/glymur/meta.yaml
#605 (comment)
:
- url: https://pypi.python.org/packages/33/6e/3bb303c46e2b9a795389115401fd32f1eff16c12a66c7a53fa36c244f9bc/Glymur-0.8.3.tar.gz
- md5: 2ff4c70a63a1e01f84b18e0ec4eb9b88
+build:
- number: 0
- script: python setup.py install --single-version-externally-managed --record record.txt
- entry_points:
- jp2dump=glymur.command_line:main
+requirements:
- build:
- python
- setuptools
- numpy >=1.7.0
- lxml >=2.3.2
- mock
Is mock a build and run dependency? Or is it just for tests?
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
https://github.com/conda-forge/staged-recipes/pull/605/files/d4229db6df4a8530c5778ff1fba2a2fc872d612a#r63207713
John Evans
There was a problem hiding this comment.
it needs it to build, but I have now removed it from the runtime deps.
Also, mock is build only?!
|
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/wcsaxes:
|
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
| test: | ||
| # Python imports | ||
| imports: | ||
| - wcsaxes |
There was a problem hiding this comment.
You could technically also run the test suite with wcsaxes.test(), it will skip the image tests anyway
There was a problem hiding this comment.
is there a better way than:
test:
commands:
- python -c "import wcsaxes; wcsaxes.test()"
??
| test: | ||
| # Python imports | ||
| imports: | ||
| - wcsaxestest: |
There was a problem hiding this comment.
@Cadair - Something went wrong here?
|
@kmuehlbauer Thanks for the suggestion! |
This is a work around to get the 0.6.4 SunPy release built, it will need fixing for SunPy 0.7
|
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/glymur:
|
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
|
I think this is ready to go, at least for now. |
|
@ocefpaf @kmuehlbauer - I think this is ready to merge? |
|
@ocefpaf Can you have a look onto the mkl pinning? I have no idea, if this has side effects. Unfortunately there is no solution from continuum so far. |
|
Once the bug is fixed I will remove the mkl pin, unless someone else has another solution. |
| build: | ||
| - python | ||
| - setuptools | ||
| - numpy >=1.7.0 |
There was a problem hiding this comment.
In theory is not need as we only build numpy > 1.9 already, but I guess it does not hurt.
There was a problem hiding this comment.
i suppose the only use would be if someone has some custom packages coming from somewhere else. It's probably worth keeping.
|
@Cadair this is good to merge. I made a few minor comments, but I can merge as soon as you give me the go with or without them. |
|
@ocefpaf Small fixes pushed, I am ready when you are. |
|
Wooo the build passed! |
|
Thanks very much @ocefpaf |
|
Thanks for the recipes @Cadair. Let me know if you have any questions about conda-forge. |
|
@ocefpaf the only remaing build question is what caused this: https://ci.appveyor.com/project/conda-forge/staged-recipes/build/1.0.2359/job/y263lbubo8aoxw18#L675 I have worked around it for now. |
|
@Cadair open an issue for that in the feedstock and we can take a look at that. (I am in a conference right now with limited access to internet, so it might take a while for me to get back to that.) |
|
@ocefpaf cool. |
|
Could someone please open a bug for the |
There is no |
|
thanks @jakirkham I noticed the lack of |
I think all the other deps are already in conda-force or defaults, so I think this is all I need!