add zarr recipe #627
add zarr recipe #627
Conversation
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
|
It looks like the fasteners package which is a runtime dependency of zarr is not available in the default conda channels. It is available on anaconda from chilipp/fasteners. Can you advise on the best way to satisfy this dependency? |
| requirements: | ||
| build: | ||
| - python | ||
| - pip |
You can download the tarball from that channel and adapt the recipe you will find in the |
|
Thanks. Should I include the fasteners recipe within this PR or make a On Tuesday, 17 May 2016, Filipe notifications@github.com wrote:
Alistair Miles |
It is fine to add it here. We don't recommend adding tons of recipes in one go, but 2-3 is fine. |
|
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/fasteners:
For recipes/monotonic:
For recipes/zarr:
|
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
|
@ocefpaf I've added recipes for fasteners (dependency of zarr) and monotonic (dependency of fasteners). Looks like builds are passing now. |
|
|
||
| about: | ||
| home: https://github.com/harlowja/fasteners | ||
| license: Apache Software License |
There was a problem hiding this comment.
Do you know which version of the Apache license? Apache-2.0?
|
@alimanfoo everything looks good. Just a minor question regarding the license version and this is good to go. |
|
Thanks @ocefpaf, licenses fixed. |
|
Thanks @ocefpaf. Can I ask, what is the recommended process for inviting the developers of monotonic and fasteners to become maintainers of the respective feedstocks? |
|
There is no hard rule. Basically you have to explain to them what is conda-forge and what is expect of the maintainer, like merge an eventual maintenance PR, or updating the to the latest release . |
|
If you would like, you can steal one of my old comments and tweak them. Here is one I did for |
|
Thanks both. What is the process for adding someone to a conda-forge team, On Wednesday, May 18, 2016, jakirkham <notifications@github.com
Alistair Miles |
|
@alimanfoo you need to add their GitHub handle as maintainers via a PR to the recipe/team you want them to be a part of. |
|
Sorry, not quite following. Do you mean I need to add their github handle On Wednesday, May 18, 2016, Filipe notifications@github.com wrote:
Alistair Miles |
|
Yes, exactly. Make sure to make this change in your fork and PR it back to the main repo. |
|
OK, thanks. For other changes to the recipe like increasing the version On Wednesday, May 18, 2016, jakirkham notifications@github.com wrote:
Alistair Miles |
|
@alimanfoo you should always submit PRs, but you don't need to bump the builder number nor wait for CIs when adding/removing maintainers. |
|
Also it is good practice to get them to sign off somehow. |
|
Sorry, what do you mean by sign off? On Wednesday, 18 May 2016, jakirkham notifications@github.com wrote:
Alistair Miles |
|
Alright, let me try to rephrase. Please only add people as maintainers when they have given their consent. Does that make sense? |
|
Ah, yes of course. On Thursday, 19 May 2016, jakirkham notifications@github.com wrote:
Alistair Miles |
No description provided.