-
-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add fltk #6587
Add fltk #6587
Conversation
Tested on Mac OS X, should work on linux
This isn't what's recommended in README.CMake.txt, but it builds without fuss on AppVeyor
Avoids [undesireable gunzipping](https://groups.google.com/forum/#!topic/fltkgeneral/uAUwCTjf8LY)
CMake does weird things with OpenGL on Mac OS X
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/fltk:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
additional deps
recipes/fltk/meta.yaml
Outdated
- {{ compiler('cxx') }} | ||
- {{ compiler('fortran') }} | ||
- cmake | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
regarding the log from the windows build:
cannot find system zlib library - using built-in
--
cannot find system jpeg library - using built-in
--
cannot find system png library - using built-in
these libraries could be added as host and run-dependencies:
host:
- zlib
- jpeg
- libpng
run:
- zlib
- jpeg
- libpng
regarding the problem on windows, it seems like this recipe should be disabled for vc < 14 but somehow the test environment tries to use vc9... Maybe adding python as a host dependency solves this issue. At least I used this in the occt-feedstock. I don't know if this is good practice. Maybe someone from @conda-forge/core can have a look at the windows build. regarding the missing tests: Maybe you can check for the existence of any fltk libraries... |
btw. thanks for the work. This is really appreciated! |
[Suggestions from looooo](conda-forge#6587 (comment))
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/fltk:
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Prevents installation?
...even though it doesn't seem to do anything
recipes/fltk/meta.yaml
Outdated
- zlib | ||
- jpeg | ||
- libpng | ||
- python # [win] to try to force vc >= 14 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
instead of doing this to force vc>=14
, please do something like that in your build section:
build:
number: 0
skip: True # [win and vc<14]
this will skip the build for windows and VC less than 14
Per [suggestion](conda-forge#6587 (review)) of @marcelotrevisani.
sigh
|
Just trigger the ci again and it should work now |
@conda-forge-admin, please rerender |
@conda-forge/core please create feedstock. |
@looooo you might consider pinging @conda-forge/staged-recipes that group is a bit bigger, and all members have merge rights to staged-recipes. |
LGTM I'm going to merge this! Sorry for the delay! Thanks to put this in |
No description provided.