Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fltk #6587

Merged
merged 22 commits into from
Sep 10, 2018
Merged

Add fltk #6587

merged 22 commits into from
Sep 10, 2018

Conversation

guyer
Copy link
Contributor

@guyer guyer commented Aug 30, 2018

No description provided.

guyer added 9 commits January 30, 2018 15:00
Tested on Mac OS X, should work on linux
This isn't what's recommended in README.CMake.txt,
but it builds without fuss on AppVeyor
CMake does weird things with OpenGL on Mac OS X
@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/fltk) and found some lint.

Here's what I've got...

For recipes/fltk:

  • The "test" section was expected to be a dictionary, but got a NoneType.
  • The recipe must have some tests.
  • The "test" section was expected to be a dictionary, but got a NoneType.

Copy link
Contributor

@looooo looooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

additional deps

- {{ compiler('cxx') }}
- {{ compiler('fortran') }}
- cmake

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

regarding the log from the windows build:

cannot find system zlib library - using built-in
-- 
cannot find system jpeg library - using built-in
-- 
cannot find system png library - using built-in

these libraries could be added as host and run-dependencies:

  host:
    - zlib
    - jpeg
    - libpng
  run:
    - zlib
    - jpeg
    - libpng

@looooo
Copy link
Contributor

looooo commented Aug 30, 2018

regarding the problem on windows, it seems like this recipe should be disabled for vc < 14 but somehow the test environment tries to use vc9... Maybe adding python as a host dependency solves this issue. At least I used this in the occt-feedstock. I don't know if this is good practice. Maybe someone from @conda-forge/core can have a look at the windows build.

regarding the missing tests: Maybe you can check for the existence of any fltk libraries...

@looooo
Copy link
Contributor

looooo commented Aug 30, 2018

btw. thanks for the work. This is really appreciated!

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/fltk) and found some lint.

Here's what I've got...

For recipes/fltk:

  • The "test" section was expected to be a dictionary, but got a NoneType.
  • The recipe must have some tests.
  • Selectors are suggested to take a <two spaces>#<one space>[<expression>] form. See lines [28]
  • The "test" section was expected to be a dictionary, but got a NoneType.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/fltk) and found it was in an excellent condition.

- zlib
- jpeg
- libpng
- python # [win] to try to force vc >= 14
Copy link
Member

@marcelotrevisani marcelotrevisani Sep 5, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of doing this to force vc>=14, please do something like that in your build section:

build:
  number: 0
  skip: True  # [win and vc<14]

this will skip the build for windows and VC less than 14

@guyer
Copy link
Contributor Author

guyer commented Sep 5, 2018

sigh

Traceback (most recent call last):
  File "C:\Miniconda36-x64\lib\site-packages\conda\core\subdir_data.py", line 440, in fetch_repodata_remote_request
    resp.raise_for_status()
  File "C:\Miniconda36-x64\lib\site-packages\requests\models.py", line 935, in raise_for_status
    raise HTTPError(http_error_msg, response=self)
requests.exceptions.HTTPError: 404 Client Error: None for url: file:///C:/Miniconda36-x64/conda-bld/noarch/repodata.json
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
  File ".ci_support\build_all.py", line 83, in <module>
    build_all(args.recipes_dir, args.arch)
  File ".ci_support\build_all.py", line 35, in build_all
    index = conda_build.conda_interface.get_index(channel_urls=channel_urls)
  File "C:\Miniconda36-x64\lib\site-packages\conda\common\io.py", line 46, in decorated
    return f(*args, **kwds)
  File "C:\Miniconda36-x64\lib\site-packages\conda\core\index.py", line 65, in get_index
    index = fetch_index(channel_urls, use_cache=use_cache)
  File "C:\Miniconda36-x64\lib\site-packages\conda\core\index.py", line 83, in fetch_index
    index = collect_all_repodata_as_index(use_cache, channel_urls)
  File "C:\Miniconda36-x64\lib\site-packages\conda\core\subdir_data.py", line 619, in collect_all_repodata_as_index
    index.update(sd.iter_dists_records())
  File "C:\Miniconda36-x64\lib\site-packages\conda\core\subdir_data.py", line 175, in iter_dists_records
    self.load()
  File "C:\Miniconda36-x64\lib\site-packages\conda\core\subdir_data.py", line 149, in load
    _internal_state = self._load()
  File "C:\Miniconda36-x64\lib\site-packages\conda\core\subdir_data.py", line 227, in _load
    mod_etag_headers.get('_mod'))
  File "C:\Miniconda36-x64\lib\site-packages\conda\core\subdir_data.py", line 571, in fetch_repodata_remote_request
    caused_by=e)
conda.exceptions.CondaHTTPError: HTTP 404 CONNECTION FAILED for url <file:///C:/Miniconda36-x64/conda-bld/noarch/repodata.json>
Elapsed: 00:00.000120
The remote server could not find the noarch directory for the
requested channel with url: file:///C:/Miniconda36-x64/conda-bld
As of conda 4.3, a valid channel must contain a `noarch/repodata.json` and
associated `noarch/repodata.json.bz2` file, even if `noarch/repodata.json` is
empty. please request that the channel administrator create
`noarch/repodata.json` and associated `noarch/repodata.json.bz2` files.
$ mkdir noarch
$ echo '{}' > noarch/repodata.json
$ bzip2 -k noarch/repodata.json
You will need to adjust your conda configuration to proceed.

@marcelotrevisani
Copy link
Member

Just trigger the ci again and it should work now

@guyer
Copy link
Contributor Author

guyer commented Sep 9, 2018

@conda-forge-admin, please rerender

@looooo
Copy link
Contributor

looooo commented Sep 9, 2018

@conda-forge/core please create feedstock.

@CJ-Wright
Copy link
Member

@looooo you might consider pinging @conda-forge/staged-recipes that group is a bit bigger, and all members have merge rights to staged-recipes.

@marcelotrevisani
Copy link
Member

LGTM

I'm going to merge this! Sorry for the delay!

Thanks to put this in conda-forge! :)

@marcelotrevisani marcelotrevisani merged commit 36348b4 into conda-forge:master Sep 10, 2018
@guyer guyer deleted the fltk branch September 10, 2018 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants