-
-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add astral 1.6.1 recipe #6623
add astral 1.6.1 recipe #6623
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small comment, but otherwise looks good to me. I'm happy to merge once it's noarch
and the conda-build issue is fixed.
recipes/astral/meta.yaml
Outdated
sha256: ab0c08f2467d35fcaeb7bad15274743d3ac1ad18b5391f64a0058a9cd192d37d | ||
|
||
build: | ||
#noarch: python |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should probably be a noarch
package.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed! I commented it out to test if it was responsible for the failure, which we now know is due an upstream conda-build issue. I'll uncomment this and rebuild after that is fixed (and address any real build issues that may come up!)
Thanks @marcelotrevisani for the commit ;) |
LGTM |
No description provided.