Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add noteslib #9735

Merged
merged 14 commits into from
Oct 4, 2019
Merged

Add noteslib #9735

merged 14 commits into from
Oct 4, 2019

Conversation

oblute
Copy link
Contributor

@oblute oblute commented Oct 3, 2019

Checklist

  • License file is packaged (see here for an example)
  • Source is from official source
  • Package does not vend other packages
  • Build number is 0
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details)
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/noteslib) and found some lint.

Here's what I've got...

For recipes/noteslib:

  • Selectors are suggested to take a <two spaces>#<one space>[<expression>] form. See lines [14]

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/noteslib) and found it was in an excellent condition.

@oblute
Copy link
Contributor Author

oblute commented Oct 3, 2019

@benhuff @mwilson8 agree to be maintainers?

@oblute
Copy link
Contributor Author

oblute commented Oct 4, 2019

@marcelotrevisani above changes made

@oblute
Copy link
Contributor Author

oblute commented Oct 4, 2019

@conda-forge/help-python this recipe is ready for final review

@marcelotrevisani marcelotrevisani merged commit 0351ae6 into conda-forge:master Oct 4, 2019
@oblute oblute deleted the noteslib branch October 4, 2019 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants