Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.11 rcs: tf rc2, est rc0 #280

Closed
wants to merge 13 commits into from
Closed

2.11 rcs: tf rc2, est rc0 #280

wants to merge 13 commits into from

Conversation

ngam
Copy link
Contributor

@ngam ngam commented Oct 29, 2022

Now:

  • the rerenderer isn't adding py311 for some reason, dropping py37 though
  • bizarre solvability failure on osx-64 only
    • Can you try renaming grpc-cpp -> libgrpc and rerendering?

Next:

  • if builds here simply time out, I will proceed to testing locally on:
    • linux-64
    • linux-64 cuda112
    • osx-64
    • osx-arm64

--

resolves #279
closes #281
closes #282

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@ngam
Copy link
Contributor Author

ngam commented Oct 29, 2022

@conda-forge-admin, please rerender.

@conda-forge conda-forge deleted a comment from github-actions bot Oct 29, 2022
@conda-forge conda-forge deleted a comment from github-actions bot Oct 29, 2022
conda-forge-webservices[bot] and others added 2 commits October 29, 2022 02:20
@conda-forge conda-forge deleted a comment from github-actions bot Oct 29, 2022
@ngam ngam changed the title 2.11 rcs 2.11 rcs: tf rc1, est rc0 Oct 29, 2022
@h-vetinari
Copy link
Member

I don't understand where the migrator get's hung up here... libgrpc definitely exists.

Can you try renaming grpc-cpp -> libgrpc and rerendering?

@h-vetinari
Copy link
Member

Interestingly, this only seems to occur on osx...? 🤔

@ngam
Copy link
Contributor Author

ngam commented Oct 29, 2022

Yes, my guess is that it is another missing dep somewhere in the chain. I looked around and I couldn't find it. Sometimes osx runners fail and they end up not uploading...

grpc-cpp is available on osx-64:
(310x64) ~$ mamba install grpc-cpp

                  __    __    __    __
                 /  \  /  \  /  \  /  \
                /    \/    \/    \/    \
███████████████/  /██/  /██/  /██/  /████████████████████████
              /  / \   / \   / \   / \  \____
             /  /   \_/   \_/   \_/   \    o \__,
            / _/                       \_____/  `
            |/
        ███╗   ███╗ █████╗ ███╗   ███╗██████╗  █████╗
        ████╗ ████║██╔══██╗████╗ ████║██╔══██╗██╔══██╗
        ██╔████╔██║███████║██╔████╔██║██████╔╝███████║
        ██║╚██╔╝██║██╔══██║██║╚██╔╝██║██╔══██╗██╔══██║
        ██║ ╚═╝ ██║██║  ██║██║ ╚═╝ ██║██████╔╝██║  ██║
        ╚═╝     ╚═╝╚═╝  ╚═╝╚═╝     ╚═╝╚═════╝ ╚═╝  ╚═╝

        mamba (0.27.0) supported by @QuantStack

        GitHub:  https://github.com/mamba-org/mamba
        Twitter: https://twitter.com/QuantStack

█████████████████████████████████████████████████████████████


Looking for: ['grpc-cpp']

conda-forge/osx-64                                          Using cache
conda-forge/noarch                                          Using cache

Pinned packages:
  - python 3.10.*


Transaction

  Prefix: /Users/ngam/.Mambaforge-MacOSX-arm64/envs/310x64

  Updating specs:

   - grpc-cpp
   - ca-certificates
   - certifi
   - openssl


  Package            Version  Build               Channel                  Size
─────────────────────────────────────────────────────────────────────────────────
  Install:
─────────────────────────────────────────────────────────────────────────────────

  + c-ares            1.18.1  h0d85af4_0          conda-forge/osx-64      102kB
  + grpc-cpp          1.49.1  h694c41f_0          conda-forge/osx-64       20kB
  + libabseil     20220623.0  cxx17_h844d122_4    conda-forge/osx-64        1MB
  + libgrpc           1.49.1  h966d1d5_0          conda-forge/osx-64        4MB
  + re2           2022.06.01  hb486fe8_0          conda-forge/osx-64      206kB

  Change:
─────────────────────────────────────────────────────────────────────────────────

  - cryptography      38.0.2  py310h23bb4e6_0     conda-forge                  
  + cryptography      38.0.2  py310hdd0c95c_2     conda-forge/osx-64        1MB
  - python            3.10.6  ha7b0be1_0_cpython  conda-forge                  
  + python            3.10.6  hc14f532_0_cpython  conda-forge/osx-64       14MB

  Upgrade:
─────────────────────────────────────────────────────────────────────────────────

  - libprotobuf       3.21.7  hbc0c0cd_0          conda-forge                  
  + libprotobuf       3.21.9  hbc0c0cd_0          conda-forge/osx-64        2MB
  - openssl           1.1.1q  hfe4f2af_0          conda-forge                  
  + openssl            3.0.5  hfd90126_2          conda-forge/osx-64     Cached

  Summary:

  Install: 5 packages
  Change: 2 packages
  Upgrade: 2 packages

  Total download: 23MB

─────────────────────────────────────────────────────────────────────────────────

Confirm changes: [Y/n] 


@h-vetinari
Copy link
Member

Yeah, that's why I said it should be ready. But it would probably surface a clearer error if we depended on libgrpc (and that's also the way of the future ;-)).

@ngam
Copy link
Contributor Author

ngam commented Oct 29, 2022

Yeah, that's why I said it should be ready. But it would probably surface a clearer error if we depended on libgrpc (and that's also the way of the future ;-)).

Will do, added it to the main post to keep track. I am going to let these runs keep going (since it's been more than hour) and will include it in the next iteration

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

  • It looks like the 'tensorflow-base' output doesn't have any tests.

conda-forge-webservices[bot] and others added 2 commits October 29, 2022 09:20
@ngam ngam changed the title 2.11 rcs: tf rc1, est rc0 2.11 rcs: tf rc2, est rc0 Nov 3, 2022
conda-forge-webservices[bot] and others added 3 commits November 3, 2022 02:20
@ngam ngam mentioned this pull request Nov 18, 2022
3 tasks
@ngam ngam closed this Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

checklist for tf 2.11
3 participants