Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testpath v0.4.1 #6

Merged
merged 6 commits into from
Sep 28, 2018
Merged

testpath v0.4.1 #6

merged 6 commits into from
Sep 28, 2018

Conversation

regro-cf-autotick-bot
Copy link
Contributor

It is very likely that the current package version for this feedstock is out of date.
Notes and instructions for merging this PR:

  1. Please check that the dependencies have not changed.
  2. Please merge the PR only after the tests have passed.
  3. Feel free to push to the bot's branch to update this PR if needed.
  4. The bot will almost always only open one PR per version.

If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one.

This PR was created by the cf-regro-autotick-bot.
The cf-regro-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. If you would like a local version of this bot, you might consider using rever. Rever is a tool for automating software releases and forms the backbone of the bot's conda-forge PRing capability. Rever is both conda (conda install -c conda-forge rever) and pip (pip install re-ver) installable.
Finally, feel free to drop us a line if there are any issues!

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@ocefpaf
Copy link
Member

ocefpaf commented Sep 28, 2018

@conda-forge-admin, please rerender

@takluyver
Copy link
Contributor

Noarch chokes because there's a Windows binary executable in there as a data file. This is only used on Windows.

I actually made a separate win_cli_launchers package just with those exes to use for things like this. I could make testpath depend on that. But the same thing would come up building that package, I assume.

@ocefpaf
Copy link
Member

ocefpaf commented Sep 28, 2018

@conda-forge-admin, please rerender

@ocefpaf
Copy link
Member

ocefpaf commented Sep 28, 2018

Noarch chokes because there's a Windows binary executable in there as a data file. This is only used on Windows.

OK.

BTW, do you have a better solution for Python 2.7? Looks like testpath is py2k compatible but flit is not, but when I try to use the setup.py on Python 2.7 I get all sort of errors :-/

@takluyver
Copy link
Contributor

The setup.py should let you do pip install . - it's not designed to be invoked directly.

I don't have a great answer for using flit for this, or for when pip uses PEP 517. Flit is designed that you can use it from Python 3 to install into a Python 2 environment, but that's tricky to arrange for a conda build.

@ocefpaf
Copy link
Member

ocefpaf commented Sep 28, 2018

The setup.py should let you do pip install . - it's not designed to be invoked directly.

We don't invoke it directly, we use

python -m pip install . --no-deps --ignore-installed --no-cache-dir -vvv

in conda-forge and that setup.pydid not like it:

https://travis-ci.org/conda-forge/testpath-feedstock/jobs/434327644#L448

@takluyver
Copy link
Contributor

Ah, I see. That's a bug with flit. I think I can fix that soon.

@ocefpaf
Copy link
Member

ocefpaf commented Sep 28, 2018

Ah, I see. That's a bug with flit. I think I can fix that soon.

OK. We can re-enable py27 here when that fix is in place.

@ocefpaf ocefpaf merged commit 6404fa8 into conda-forge:master Sep 28, 2018
@takluyver
Copy link
Contributor

I've just released 0.4.2, using a development version of flit which hopefully has that bug fixed. Let me know how it goes.

(Also, I got round to changing the license from MIT to BSD - I don't know if the bot will apply that to conda automatically)

@ocefpaf
Copy link
Member

ocefpaf commented Oct 2, 2018

Also, I got round to changing the license from MIT to BSD - I don't know if the bot will apply that to conda automatically.

The bot does not handle metadata updates yet.

@jasongrout jasongrout mentioned this pull request Oct 5, 2018
jasongrout added a commit to jasongrout/jupyter-renderers that referenced this pull request Oct 5, 2018
I think this may solve the error at https://travis-ci.org/jupyterlab/jupyter-renderers/builds/437449573#L431. See conda-forge/testpath-feedstock#6 and conda-forge/testpath-feedstock#8 for details. Once testpath 4.2 is released, hopefully this is fixed.
jasongrout added a commit to jasongrout/jupyter-renderers that referenced this pull request Oct 5, 2018
Immediately, this solves the error at https://travis-ci.org/jupyterlab/jupyter-renderers/builds/437449573#L431. See conda-forge/testpath-feedstock#6 and conda-forge/testpath-feedstock#8 for details.

In general, I think it's good to test against the open conda-forge packages.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants