Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to GCC 11 #177

Merged
merged 2 commits into from
Dec 21, 2022
Merged

Migrate to GCC 11 #177

merged 2 commits into from
Dec 21, 2022

Conversation

jdblischak
Copy link
Member

conda-forge updated its GCC pinning from 10 to 11 2 weeks ago (conda-forge/conda-forge-pinning-feedstock#3731). This migration has been well tolerated by TileDB-VCF (source) and TileDB-R (source)

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@akrherz
Copy link
Contributor

akrherz commented Dec 16, 2022

Thank you. My own curiosity gets the best of me... What is driving this PR? Is there not a migrator coming or ?

@jdblischak
Copy link
Member Author

The main motivation is that this change is automatically made any time we rerender any of the other tiledb-related feedstocks. @ihnorton had me roll back the GCC migration in PR TileDB-Inc/tiledb-vcf-feedstock#60 (review) because he was worried about compatibility issues throughout the tiledb stack. But this change has already been merged to TileDB-VCF and TileDB-R seemingly without consequence, so I figured we should explicitly make the change here as well.

To summarize, as we migrate the TileDB clients to libtiledb 2.13, the conda-forge machinery is automatically bumping the GCC version. Thus I wanted to migrate the core library too. Otherwise it likely wouldn't happen until the next TileDB release

There's no rush, so we can wait until @ihnorton or @Shelnutt2 approves

@ihnorton ihnorton merged commit b9f8764 into conda-forge:main Dec 21, 2022
@jdblischak jdblischak deleted the gcc-11 branch December 21, 2022 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants