Rebuild for pytorch #28
Conversation
…nda-forge-pinning 2021.07.29.23.13.45
regro-cf-autotick-bot
requested review from
h-vetinari,
hmaarrfk and
nehaljwani
as code owners
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
h-vetinari
force-pushed
the
rebuild-pytorch-0-1_h2b1f7e
branch
from
52fe364 to
3907c43
Compare
|
Hi! This is the friendly conda-forge automerge bot! I considered the following status checks when analyzing this PR:
Thus the PR was not passing and not merged. |
h-vetinari
force-pushed
the
rebuild-pytorch-0-1_h2b1f7e
branch
from
ad2dcac to
13dd10f
Compare
|
FYI, we kinda jumped the gun on getting this merged. We still don't have full builds for Pytorch GPU 1.9.0. You might want to hold off until some columns are filled conda-forge/pytorch-cpu-feedstock#52 |
|
I'm surprised how the CI could pass here. Shouldn't the pin mean that the test environment can only be installed if the GPU build of pytorch exists already? |
|
It seems we didn't get the pin quite right. It is pulling in pytorch-gpu 1.8.0. let me see. Thanks for helping us debug and being critical! |
|
happy to see a failure. |
Co-authored-by: Mark Harfouche <mark.harfouche@gmail.com>
| @@ -1,5 +1,4 @@ | |||
| {% set version = "0.9.1" %} | |||
| {% set number = 1 %} | |||
There was a problem hiding this comment.
is this version of torchvision compatible with pytorch 1.9?
There was a problem hiding this comment.
Upstream doesn't constrain the version directly, and this feedstock had no upper pytorch requirement for as long that I'm aware. If the CI passes, I'd say it's fine.
|
|
||
| # for compatibility with (& ease of migration from) old packages in the pytorch channel, see | ||
| # https://anaconda.org/pytorch/torchvision-cpu/files | ||
| - name: torchvision-cpu |
There was a problem hiding this comment.
are we sure this is ok to remove? maybe a migrator is necessary to replace torchvision-cpu with torchvision and pytorch-cpu
There was a problem hiding this comment.
Good point, but there are no dependent packages in conda-forge either.
|
Since we run all the tests I think it is fine. |
This PR has been triggered in an effort to update pytorch.
Notes and instructions for merging this PR:
Please note that if you close this PR we presume that the feedstock has been rebuilt, so if you are going to perform the rebuild yourself don't close this PR until the your rebuild has been merged.
This package has the following downstream children:
And potentially more.
If this PR was opened in error or needs to be updated please add the
bot-rerunlabel to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase@conda-forge-admin, please rerun botin a PR comment to have theconda-forge-adminadd it for you.This PR was created by the regro-cf-autotick-bot.
The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. If you would like a local version of this bot, you might consider using rever. Rever is a tool for automating software releases and forms the backbone of the bot's conda-forge PRing capability. Rever is both conda (
conda install -c conda-forge rever) and pip (pip install re-ver) installable.Finally, feel free to drop us a line if there are any issues!
This PR was generated by https://github.com/regro/autotick-bot/actions/runs/1080536134, please use this URL for debugging