Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebuild for increased compatibility and build for python 3.12 #89

Merged
merged 16 commits into from
Feb 25, 2024

Conversation

conda-forge-admin
Copy link
Contributor

@conda-forge-admin conda-forge-admin commented Feb 24, 2024

See conda-forge/pytorch-cpu-feedstock#222

Hi! This is the friendly automated conda-forge-webservice.

I've started rerendering the recipe as instructed in #88.

If I find any needed changes to the recipe, I'll push them to this PR shortly. Thank you for waiting!

Here's a checklist to do before merging.

  • Bump the build number if needed.

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@hmaarrfk hmaarrfk changed the title MNT: rerender Rebuild for increased compatibility Feb 24, 2024
@hmaarrfk
Copy link
Contributor

Why is this never easy....

@hmaarrfk hmaarrfk changed the title Rebuild for increased compatibility Rebuild for increased compatibility and build for python 3.12 Feb 24, 2024
@Tobias-Fischer
Copy link
Contributor

This might help @hmaarrfk: pytorch/vision#8280

@hmaarrfk hmaarrfk added the automerge Merge the PR when CI passes label Feb 25, 2024
Copy link
Contributor

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

  • linter: passed
  • azure: failed

Thus the PR was not passing and not merged.

@Tobias-Fischer
Copy link
Contributor

Looks like this isn’t ready for py312 yet ..

@hmaarrfk
Copy link
Contributor

I'm going to see if i can patch out a few tests.

I had solved this 3 months ago for them: pytorch/vision#8119 and they just said: "lets hope this isn't the case"

@github-actions github-actions bot removed the automerge Merge the PR when CI passes label Feb 25, 2024
Copy link
Contributor

Hi! This is the friendly conda-forge automerge bot!

Commits were made to this PR after the automerge label was added. For security reasons, I have disabled automerge by removing the automerge label. Please add the automerge label again (or ask a maintainer to do so) if you'd like to enable automerge again!

@hmaarrfk
Copy link
Contributor

Basically the torch kit uses the abstract syntax tree from python and it is issuing some warning about some Breaking chnages happening in python 3.14. I’ve ignored the deprecation warnings and it seems to be passing. Are we ok with this?

Copy link
Member

@h-vetinari h-vetinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Completely fine with the patches, fine with (but not excited about) turning into single output. Let's just not remove things that keep the link check clean(er)

skip: true # [win]
# no CUDA-enabled pytorch on aarch yet
skip: true # [cuda_compiler_version != "None" and aarch64]
# Upstream has specific compatability ranges for pytorch and python which are
# updated every 0.x release. https://github.com/pytorch/vision#installation
skip: true # [py < 38]
skip: true # [py > 311]
rpaths:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please leave the rpath bit

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it still important now that we have libtorch that installs things in the PREFIx/lib

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. That's nice.

But it looks like pytorch needs a run-export on libtorch:

WARNING (torchvision,lib/python3.10/site-packages/torchvision/image.so): Needed DSO lib/libc10.so found in ['conda-forge/linux-64::libtorch==2.1.2=cuda112_hf51c5c5_301']
WARNING (torchvision,lib/python3.10/site-packages/torchvision/image.so): .. but ['conda-forge/linux-64::libtorch==2.1.2=cuda112_hf51c5c5_301'] not in reqs/run, (i.e. it is overlinking) (likely) or a missing dependency (less likely)
WARNING (torchvision,lib/python3.10/site-packages/torchvision/image.so): Needed DSO lib/libtorch_cpu.so found in ['conda-forge/linux-64::libtorch==2.1.2=cuda112_hf51c5c5_301']
WARNING (torchvision,lib/python3.10/site-packages/torchvision/image.so): .. but ['conda-forge/linux-64::libtorch==2.1.2=cuda112_hf51c5c5_301'] not in reqs/run, (i.e. it is overlinking) (likely) or a missing dependency (less likely)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or rather, we need to specify the host-dep on libtorch here.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still need the host-dep on pytorch? Can't we get rid of it thanks to the libtorch host-dep, and instead only have a run-dep on pytorch?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still need the host-dep on pytorch? Can't we get rid of it thanks to the libtorch host-dep, and instead only have a run-dep on pytorch?

Yeah, I think we could, but it doesn't make a big difference for now, since we still need pytorch at runtime.

Copy link
Member

@h-vetinari h-vetinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with our without the question about the pytorch host-dep. We can remove it next PR. Or now. I don't mind.

@Tobias-Fischer
Copy link
Contributor

LGTM too, thanks @hmaarrfk!

@hmaarrfk hmaarrfk merged commit b88453f into conda-forge:main Feb 25, 2024
35 of 37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants