-
-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rebuild for increased compatibility and build for python 3.12 #89
Rebuild for increased compatibility and build for python 3.12 #89
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
…nda-forge-pinning 2024.02.23.21.25.19
Why is this never easy.... |
…nda-forge-pinning 2024.02.23.21.25.19
…nda-forge-pinning 2024.02.23.21.25.19
This might help @hmaarrfk: pytorch/vision#8280 |
Hi! This is the friendly conda-forge automerge bot! I considered the following status checks when analyzing this PR:
Thus the PR was not passing and not merged. |
Looks like this isn’t ready for py312 yet .. |
I'm going to see if i can patch out a few tests. I had solved this 3 months ago for them: pytorch/vision#8119 and they just said: "lets hope this isn't the case" |
Hi! This is the friendly conda-forge automerge bot! Commits were made to this PR after the |
Basically the torch kit uses the abstract syntax tree from python and it is issuing some warning about some Breaking chnages happening in python 3.14. I’ve ignored the deprecation warnings and it seems to be passing. Are we ok with this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Completely fine with the patches, fine with (but not excited about) turning into single output. Let's just not remove things that keep the link check clean(er)
skip: true # [win] | ||
# no CUDA-enabled pytorch on aarch yet | ||
skip: true # [cuda_compiler_version != "None" and aarch64] | ||
# Upstream has specific compatability ranges for pytorch and python which are | ||
# updated every 0.x release. https://github.com/pytorch/vision#installation | ||
skip: true # [py < 38] | ||
skip: true # [py > 311] | ||
rpaths: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please leave the rpath bit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it still important now that we have libtorch that installs things in the PREFIx/lib
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No. That's nice.
But it looks like pytorch needs a run-export on libtorch:
WARNING (torchvision,lib/python3.10/site-packages/torchvision/image.so): Needed DSO lib/libc10.so found in ['conda-forge/linux-64::libtorch==2.1.2=cuda112_hf51c5c5_301']
WARNING (torchvision,lib/python3.10/site-packages/torchvision/image.so): .. but ['conda-forge/linux-64::libtorch==2.1.2=cuda112_hf51c5c5_301'] not in reqs/run, (i.e. it is overlinking) (likely) or a missing dependency (less likely)
WARNING (torchvision,lib/python3.10/site-packages/torchvision/image.so): Needed DSO lib/libtorch_cpu.so found in ['conda-forge/linux-64::libtorch==2.1.2=cuda112_hf51c5c5_301']
WARNING (torchvision,lib/python3.10/site-packages/torchvision/image.so): .. but ['conda-forge/linux-64::libtorch==2.1.2=cuda112_hf51c5c5_301'] not in reqs/run, (i.e. it is overlinking) (likely) or a missing dependency (less likely)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or rather, we need to specify the host-dep on libtorch here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we still need the host-dep on pytorch? Can't we get rid of it thanks to the libtorch host-dep, and instead only have a run-dep on pytorch?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we still need the host-dep on pytorch? Can't we get rid of it thanks to the libtorch host-dep, and instead only have a run-dep on pytorch?
Yeah, I think we could, but it doesn't make a big difference for now, since we still need pytorch at runtime.
…nda-forge-pinning 2024.02.23.21.25.19
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, with our without the question about the pytorch host-dep. We can remove it next PR. Or now. I don't mind.
LGTM too, thanks @hmaarrfk! |
See conda-forge/pytorch-cpu-feedstock#222
Hi! This is the friendly automated conda-forge-webservice.
I've started rerendering the recipe as instructed in #88.
If I find any needed changes to the recipe, I'll push them to this PR shortly. Thank you for waiting!
Here's a checklist to do before merging.