Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebuild tsid to get a build with urdfdom 3 #8

Merged
merged 2 commits into from
Jun 20, 2022

Conversation

traversaro
Copy link
Contributor

mamba create -n pintsid pinocchio=2.6.8 tsid=1.6.1 currently fails as there is no recent build of tsid compiled with the latest urdfdom, so if an user wants to install tsid it is forced to install an older version of pinocchio. This PR is a workaround for this, forcing a rebuild of tsid that will get compiled with the latest pinocchio. In a sense, this problem is similar to the one described for sdformat v9 in gazebosim/gazebo-classic#3223 (comment), and the proper solution is managing urdfdom in https://github.com/conda-forge/conda-forge-pinning-feedstock, as proposed in conda-forge/conda-forge-pinning-feedstock#2925 .

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@traversaro
Copy link
Contributor Author

@conda-forge-admin, please rerender

Copy link
Contributor

@jcarpent jcarpent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@traversaro Thanks for your great efforts.
Is it ready to be merged?

@traversaro
Copy link
Contributor Author

Is it ready to be merged?

Yes!

@jcarpent jcarpent merged commit d4a1109 into conda-forge:main Jun 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants